| Message ID | m1zky26iaw.fsf_-_@fess.ebiederm.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2010-07-08 at 09:37 -0700, Eric W. Biederman wrote: > Don't call SET_IEEE80211_DEV. This weakens the connections between > the phy files in sysfs slightly but otherwise it makes the driver work > in the face of tagged sysfs support. > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> > --- > > Johannes does this change look usable? It'll probably work, but anything in userspace relying on it will fail, and you'll have some unused virtual devices in sysfs? Not too keen on it, but if we really can't fix it .... johannes > drivers/net/wireless/mac80211_hwsim.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c > index 6f8cb3e..b387222 100644 > --- a/drivers/net/wireless/mac80211_hwsim.c > +++ b/drivers/net/wireless/mac80211_hwsim.c > @@ -1282,7 +1282,6 @@ static int __init init_mac80211_hwsim(void) > } > data->dev->driver = &mac80211_hwsim_driver; > > - SET_IEEE80211_DEV(hw, data->dev); > addr[3] = i >> 8; > addr[4] = i; > memcpy(data->addresses[0].addr, addr, ETH_ALEN); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Johannes Berg <johannes@sipsolutions.net> writes: > On Thu, 2010-07-08 at 09:37 -0700, Eric W. Biederman wrote: >> Don't call SET_IEEE80211_DEV. This weakens the connections between >> the phy files in sysfs slightly but otherwise it makes the driver work >> in the face of tagged sysfs support. >> >> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> >> --- >> >> Johannes does this change look usable? > > It'll probably work, but anything in userspace relying on it will fail, > and you'll have some unused virtual devices in sysfs? Well anything in userspace that isn't mac80211_hwsim specific will likely already fail because the format of the link is different for mac80211_hwsim then for every other wireless device. > Not too keen on it, but if we really can't fix it .... Perhaps. I'm not familiar enough with the details of the device layer to promise an eta on anything like that. Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2010-07-12 at 07:23 -0700, Eric W. Biederman wrote: > > It'll probably work, but anything in userspace relying on it will fail, > > and you'll have some unused virtual devices in sysfs? > > Well anything in userspace that isn't mac80211_hwsim specific will > likely already fail because the format of the link is different for > mac80211_hwsim then for every other wireless device. Well, I seem to have a vague memory of network-manager for example requiring the link but not really caring much what it is, but I might remember something else that wasn't hwsim related. johannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 6f8cb3e..b387222 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -1282,7 +1282,6 @@ static int __init init_mac80211_hwsim(void) } data->dev->driver = &mac80211_hwsim_driver; - SET_IEEE80211_DEV(hw, data->dev); addr[3] = i >> 8; addr[4] = i; memcpy(data->addresses[0].addr, addr, ETH_ALEN);
Don't call SET_IEEE80211_DEV. This weakens the connections between the phy files in sysfs slightly but otherwise it makes the driver work in the face of tagged sysfs support. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> --- Johannes does this change look usable? drivers/net/wireless/mac80211_hwsim.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)