From patchwork Tue Apr 24 21:17:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Ricardo Leitner X-Patchwork-Id: 903876 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JyqowZl0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Vx4v1MWYz9ryr for ; Wed, 25 Apr 2018 07:18:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751271AbeDXVSE (ORCPT ); Tue, 24 Apr 2018 17:18:04 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:37391 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbeDXVR5 (ORCPT ); Tue, 24 Apr 2018 17:17:57 -0400 Received: by mail-qt0-f194.google.com with SMTP id w12-v6so24158593qti.4; Tue, 24 Apr 2018 14:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nsRAWipdVhqO2DZIoyDdsfB8spUmAktdKF6F+yo+/dc=; b=JyqowZl0bSn+wlvjmSDUNcUpcU74AW0urPF6XcTy5kYRVg2X4jOaSN6WNZTCdXx7aN Siigy+nYC80WUZluQf03SZ+R+tLbO06EG+ZZamQGqmvezCu/PmgC8axeqiLN0Qinm96y CSx9xmO2zIC1Ra86C6R7OOhwjBZ4jBlDiEpTTkdttFCRXYh/htvaEyi50u+Apo9hx4wp WZ5t+0NEyJ8KmHwrmAI23y575r1/Wefav7H+oWEo2UGRWEIoO7wuNHQ36uzHloylh6y+ Ml315SGlo4RB5f9vhcmLPipIE3qEUDCkAOUr23e9VKL6/HED1ITHY3QwTrDwaXH+38k2 KYhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nsRAWipdVhqO2DZIoyDdsfB8spUmAktdKF6F+yo+/dc=; b=gJ7duthYehEGiiN69+3o5Za3JtgCHzj4P5zRIspGHTplBX69r5jX9caIVWc+sByh05 m10uKqvjUhqL/yfTiKaTMQe8CPA8yjmzyv94s8DCmGBCxPCJaBxRUmgv4Ko/uzKXMWwN 1u1j8oQbn8S33Jy7z8a61Y/sQ4NIVHQ4Pb+QIts1I0ksO252jw1d5dkWvHntbTyIFmQo lPa7a2+ZbUtUQFfaBNFYMBPpcwjjqww1rzuruMpW0lWrv9y2Cmcls9QpFj4Jk/F/k6Nd B8t+Kqf/y+2JrVkZhBk1EAMdiwOX7JvfyBAwCsycWpK+M0VoH+n+3lK0dBrYPEhZnd+k rYAQ== X-Gm-Message-State: ALQs6tBNpjtGSQQSrRcwWrcnob3GLElgp6hwUjVSE80tPV85k3Y3Avip 1/vDFLtmEggWtP3gtvrrIYU= X-Google-Smtp-Source: AB8JxZrEvcXPFGNOIFtGDrgCGUIG2pMBeJG3X+l4S5CH3o0mM8ttjnyn+7XEafg/mXmsklj7i/+c3g== X-Received: by 10.12.138.188 with SMTP id 57mr5677797qvv.147.1524604676288; Tue, 24 Apr 2018 14:17:56 -0700 (PDT) Received: from localhost.localdomain ([177.10.56.96]) by smtp.gmail.com with ESMTPSA id a47-v6sm13860239qta.17.2018.04.24.14.17.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 14:17:55 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 2AE30181E39; Tue, 24 Apr 2018 18:17:53 -0300 (-03) From: Marcelo Ricardo Leitner To: netdev@vger.kernel.org Cc: linux-sctp@vger.kernel.org, Xin Long , Vlad Yasevich , Neil Horman Subject: [PATCH net-next] sctp: fix const parameter violation in sctp_make_sack Date: Tue, 24 Apr 2018 18:17:34 -0300 Message-Id: X-Mailer: git-send-email 2.14.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org sctp_make_sack() make changes to the asoc and this cast is just bypassing the const attribute. As there is no need to have the const there, just remove it and fix the violation. Signed-off-by: Marcelo Ricardo Leitner Reviewed-by: Xin Long Acked-by: Neil Horman peer.tsn_map; - struct sctp_association *aptr = (struct sctp_association *)asoc; struct sctp_gap_ack_block gabs[SCTP_MAX_GABS]; __u16 num_gabs, num_dup_tsns; struct sctp_transport *trans; @@ -857,7 +856,7 @@ struct sctp_chunk *sctp_make_sack(const struct sctp_association *asoc) /* Add the duplicate TSN information. */ if (num_dup_tsns) { - aptr->stats.idupchunks += num_dup_tsns; + asoc->stats.idupchunks += num_dup_tsns; sctp_addto_chunk(retval, sizeof(__u32) * num_dup_tsns, sctp_tsnmap_get_dups(map)); } @@ -869,11 +868,11 @@ struct sctp_chunk *sctp_make_sack(const struct sctp_association *asoc) * association so no transport will match after a wrap event like this, * Until the next sack */ - if (++aptr->peer.sack_generation == 0) { + if (++asoc->peer.sack_generation == 0) { list_for_each_entry(trans, &asoc->peer.transport_addr_list, transports) trans->sack_generation = 0; - aptr->peer.sack_generation = 1; + asoc->peer.sack_generation = 1; } nodata: return retval;