From patchwork Wed May 16 00:49:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Leitner X-Patchwork-Id: 914095 X-Patchwork-Delegate: dsahern@gmail.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40lwp66xkJz9s0W for ; Wed, 16 May 2018 10:50:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbeEPAuR (ORCPT ); Tue, 15 May 2018 20:50:17 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751402AbeEPAuQ (ORCPT ); Tue, 15 May 2018 20:50:16 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ECE6F4201AE3 for ; Wed, 16 May 2018 00:50:15 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-3.gru2.redhat.com [10.97.116.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9EDF264687 for ; Wed, 16 May 2018 00:50:15 +0000 (UTC) Received: by localhost.localdomain (Postfix, from userid 1000) id ECAD01810A7; Tue, 15 May 2018 21:50:12 -0300 (-03) From: Marcelo Ricardo Leitner To: netdev@vger.kernel.org Subject: [PATCH iproute2-next] tc-netem: fix limit description in man page Date: Tue, 15 May 2018 21:49:55 -0300 Message-Id: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 16 May 2018 00:50:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 16 May 2018 00:50:15 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mleitner@redhat.com' RCPT:'' Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org As the kernel code says, limit is actually the amount of packets it can hold queued at a time, as per: static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, struct sk_buff **to_free) { ... if (unlikely(sch->q.qlen >= sch->limit)) return qdisc_drop_all(skb, sch, to_free); So lets fix the description of the field in the man page. Signed-off-by: Marcelo Ricardo Leitner --- man/man8/tc-netem.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/tc-netem.8 b/man/man8/tc-netem.8 index b31384f57a9b36769c0037c465cc6b5bbe8c8b6e..f2cd86b6ed8ae82b8cc2fbd2ecbe41d2fcbad507 100644 --- a/man/man8/tc-netem.8 +++ b/man/man8/tc-netem.8 @@ -65,7 +65,7 @@ netem has the following options: .SS limit packets -limits the effect of selected options to the indicated number of next packets. +maximum number of packets the qdisc may hold queued at a time. .SS delay adds the chosen delay to the packets outgoing to chosen network interface. The