| Message ID | a5348ef4-24be-ece0-c9b2-27c8dc7e0c06@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] r8169: fix jumbo configuration for RTL8168evl | expand |
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Sun, 1 Dec 2019 10:27:14 +0100 > Alan reported [0] that network is broken since the referenced commit > when using jumbo frames. This commit isn't wrong, it just revealed > another issue that has been existing before. According to the vendor > driver the RTL8168e-specific jumbo config doesn't apply for RTL8168evl. > > [0] https://lkml.org/lkml/2019/11/30/119 > > Fixes: 4ebcb113edcc ("r8169: fix jumbo packet handling on resume from suspend") > Reported-by: Alan J. Wylie <alan@wylie.me.uk> > Tested-by: Alan J. Wylie <alan@wylie.me.uk> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied and queued up for -stable.
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 0b47db2ff..38d212686 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -3873,7 +3873,7 @@ static void rtl_hw_jumbo_enable(struct rtl8169_private *tp) case RTL_GIGA_MAC_VER_27 ... RTL_GIGA_MAC_VER_28: r8168dp_hw_jumbo_enable(tp); break; - case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_34: + case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33: r8168e_hw_jumbo_enable(tp); break; default:
Alan reported [0] that network is broken since the referenced commit when using jumbo frames. This commit isn't wrong, it just revealed another issue that has been existing before. According to the vendor driver the RTL8168e-specific jumbo config doesn't apply for RTL8168evl. [0] https://lkml.org/lkml/2019/11/30/119 Fixes: 4ebcb113edcc ("r8169: fix jumbo packet handling on resume from suspend") Reported-by: Alan J. Wylie <alan@wylie.me.uk> Tested-by: Alan J. Wylie <alan@wylie.me.uk> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)