| Message ID | OFDC737720.EA272892-ONC1258073.00458CA2-C1258073.0049AC0D@continental-corporation.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
Hi Daniel, Thanks for fixing this. I noticed it some time ago but it seems I forgot to send the patch :( Acked-by: Sabrina Dubroca <sd@queasysnail.net> Your subject line should be: Subject: [PATCH iproute2] macsec: Nr.of packets and octets for macsec tx stats were swapped. with "iproute2" between the brackets. 2016-11-22, 14:24:40 +0100, Daniel.Hopf@continental-corporation.com wrote: > Signed-off-by: Daniel Hopf <daniel.hopf@continental-corporation.com> > --- > ip/ipmacsec.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c > index c9252bb..aa89a00 100644 > --- a/ip/ipmacsec.c > +++ b/ip/ipmacsec.c > @@ -634,10 +634,10 @@ static void print_one_stat(const char **names, > struct rtattr **attr, int idx, > } > > static const char *txsc_stats_names[NUM_MACSEC_TXSC_STATS_ATTR] = { > - [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = > "OutOctetsProtected", > - [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = > "OutOctetsEncrypted", > - [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = > "OutPktsProtected", > - [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = > "OutPktsEncrypted", > + [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = "OutPktsProtected", > + [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = "OutPktsEncrypted", > + [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = > "OutOctetsProtected", > + [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = > "OutOctetsEncrypted", > }; Your patch was corrupted, probably by your email client, you have extra newlines everywhere. Can you send a v2 of this patch? Thanks!
Hi, Daniel
Acked-by: Rami Rosen <roszenrami@gmail.com>
Agreed about Sabrina comments about adding iproute2 and about the newlines.
Regards,
R
diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c index c9252bb..aa89a00 100644 --- a/ip/ipmacsec.c +++ b/ip/ipmacsec.c @@ -634,10 +634,10 @@ static void print_one_stat(const char **names, struct rtattr **attr, int idx, } static const char *txsc_stats_names[NUM_MACSEC_TXSC_STATS_ATTR] = { - [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = "OutOctetsProtected", - [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = "OutOctetsEncrypted", - [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = "OutPktsProtected", - [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = "OutPktsEncrypted", + [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = "OutPktsProtected", + [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = "OutPktsEncrypted",
Signed-off-by: Daniel Hopf <daniel.hopf@continental-corporation.com> --- ip/ipmacsec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) + [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = "OutOctetsProtected", + [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = "OutOctetsEncrypted", }; static void print_txsc_stats(const char *prefix, struct rtattr *attr) -- 2.9.3