| Message ID | E1YZarc-0000vx-O6@gondolin.me.apana.org.au |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 03/22/15 at 07:04pm, Herbert Xu wrote: > This patch removes the explicit jhash value for the hashfn parameter > of rhashtable. The default is now jhash so removing the setting > makes no difference apart from making one less copy of jhash in > the kernel. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Looks likes this is not needed given Patrick's work. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Mar 22, 2015 at 11:56:59AM +0000, Thomas Graf wrote: > On 03/22/15 at 07:04pm, Herbert Xu wrote: > > This patch removes the explicit jhash value for the hashfn parameter > > of rhashtable. The default is now jhash so removing the setting > > makes no difference apart from making one less copy of jhash in > > the kernel. > > > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> > > Looks likes this is not needed given Patrick's work. OK dropped.
diff --git a/net/netfilter/nft_hash.c b/net/netfilter/nft_hash.c index 4585c57..3bda4e7 100644 --- a/net/netfilter/nft_hash.c +++ b/net/netfilter/nft_hash.c @@ -13,7 +13,6 @@ #include <linux/module.h> #include <linux/list.h> #include <linux/log2.h> -#include <linux/jhash.h> #include <linux/netlink.h> #include <linux/rhashtable.h> #include <linux/netfilter.h> @@ -169,7 +168,6 @@ static unsigned int nft_hash_privsize(const struct nlattr * const nla[]) static const struct rhashtable_params nft_hash_params = { .head_offset = offsetof(struct nft_hash_elem, node), .key_offset = offsetof(struct nft_hash_elem, key), - .hashfn = jhash, }; static int nft_hash_init(const struct nft_set *set,
This patch removes the explicit jhash value for the hashfn parameter of rhashtable. The default is now jhash so removing the setting makes no difference apart from making one less copy of jhash in the kernel. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> --- net/netfilter/nft_hash.c | 2 -- 1 file changed, 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html