From patchwork Sun Jan 6 00:02:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 1021026 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=hotmail.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43XJcZ4Vfrz9sCr for ; Sun, 6 Jan 2019 11:02:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbfAFACc (ORCPT ); Sat, 5 Jan 2019 19:02:32 -0500 Received: from mail-oln040092064070.outbound.protection.outlook.com ([40.92.64.70]:51264 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726363AbfAFACc (ORCPT ); Sat, 5 Jan 2019 19:02:32 -0500 Received: from HE1EUR01FT038.eop-EUR01.prod.protection.outlook.com (10.152.0.55) by HE1EUR01HT069.eop-EUR01.prod.protection.outlook.com (10.152.1.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13; Sun, 6 Jan 2019 00:02:28 +0000 Received: from DB7PR07MB5353.eurprd07.prod.outlook.com (10.152.0.58) by HE1EUR01FT038.mail.protection.outlook.com (10.152.1.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13 via Frontend Transport; Sun, 6 Jan 2019 00:02:28 +0000 Received: from DB7PR07MB5353.eurprd07.prod.outlook.com ([fe80::e1f9:8635:f629:eb8e]) by DB7PR07MB5353.eurprd07.prod.outlook.com ([fe80::e1f9:8635:f629:eb8e%4]) with mapi id 15.20.1516.010; Sun, 6 Jan 2019 00:02:28 +0000 From: Bernd Edlinger To: Ping-Ke Shih , Larry Finger , Kalle Valo , "David S. Miller" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Lunn Subject: [PATCH v3 2/4] rtl8723ae: Dont use old data for input gain control Thread-Topic: [PATCH v3 2/4] rtl8723ae: Dont use old data for input gain control Thread-Index: AQHUpVMclX/eeo4ws0GaQg3rMsPG2Q== Date: Sun, 6 Jan 2019 00:02:28 +0000 Message-ID: Accept-Language: en-US, en-GB, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR06CA0010.eurprd06.prod.outlook.com (2603:10a6:20b:14::23) To DB7PR07MB5353.eurprd07.prod.outlook.com (2603:10a6:10:6e::26) x-incomingtopheadermarker: OriginalChecksum:CDBF9722D95F050B2011D2967DF567538F39DEFFFBFAC8EA57C8213EF08C0CF6; UpperCasedChecksum:B9B519704729FC20E1866FF6FB9CC148C3957D79B1CE353D905C698774844B40; SizeAsReceived:8783; Count:62 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [PWlwFVUiSpt8yOB4yHpdJuWceFOPGbXL] x-microsoft-original-message-id: <37150adc-d0d4-d543-b949-07c9d42448d0@hotmail.de> x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1EUR01HT069; 6:sEQR97FnzIIia+5mMH5pzrecS4QjLhtClsumgmqO6K7WEBcvELZNfb4uY71GCj8km014MHiEGSd3P6gMgHwcOnK5IAQNew2K5oE0ImSpcSIbHeO0BgYNdbfP0QdOxsbgQ9M5zaxskf1IXyjmnwuM2Br/8YWJDh+HTQuNlGgoFRfrtrWqpatARC8NH+1W+bGud9OFu8DDHz0fsv72fQ3tYrhoKKYvuVDNVxxzQJaIdRexy7gl/BEE8kJfp0B5kyMcI0MpQ4RCBodhrtNTnCCJ4KYxD5aUW3AThL0xXuULKKWsG5raUzgTPXDUL2oMF0om8oW7Jjtn0YnFobYiLdVQ+/4oQ5g6DdJNywyqM8eFgByWdg/LA/iIm3MjSS/DrEn5eaCq0Z16eCfsu25qXpmWnX7P2URchU5X3GFygia+iwBWCi9FDCSLAKD8k6IMFIDb69cBBClh1EbY7EcnNq2Q1Q==; 5:h5OOEV4BXKy2zPGFh7/KzpGyma+YtfPROSqJkKrCUNQtLnWUoMwdajl7aqyOQo8mG/FjGpfSDcMB+ulqfbEUHJpB0tsbNikNotijssfH15a2DI+sbKFfpkCWckyd1lLZKDAWuoqqBoRfKdpW/BuUOzpswO2MKlY786cFo0rUSkw=; 7:DBa/6Pw3YUI6stvP0sbJx7ns7C0pKkuG1PZ7HJEFjBuXI3HzSjRIh2deB4LQLvPR9mBiKCYpcr/dJd9ZFoAJ4moa4TDbKWljcpBqCA+c9SYWv7F3jZ9FRgPC5S6SGbBEYRCGV9zlrZ+Tuq4McYOFWw== x-incomingheadercount: 62 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(20181119063)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:HE1EUR01HT069; x-ms-traffictypediagnostic: HE1EUR01HT069: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); SRVR:HE1EUR01HT069; BCL:0; PCL:0; RULEID:; SRVR:HE1EUR01HT069; x-microsoft-antispam-message-info: wvbHOGd/WCAUYDK9kxg+oh61DP6v7J/KTNiGtFCmJIcWBSzMBdV1iDU0B3Sjb9/J Content-ID: MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: d4d70346-2c10-4f39-8c00-e767963926d9 X-MS-Exchange-CrossTenant-Network-Message-Id: 8bbd1aae-4ca3-43d4-32eb-08d6736a3f32 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: d4d70346-2c10-4f39-8c00-e767963926d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2019 00:02:27.8485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT069 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When no beacon was received, the value in dm.undec_sm_pwdb is most likely out of date and should not be used to adjust the input path. Assume instead that the signal level is low. Fix the state machine in rtl8723e_dm_cck_packet_detection_thresh which did not clear pre_cck_fa_state when changing cur_cck_pd_state from CCK_PD_STAGE_LOWRSSI/CCK_FA_STAGE_LOW to CCK_PD_STAGE_HIGHRSSI and back again to CCK_PD_STAGE_LOWRSSI/CCK_FA_STAGE_LOW, the register RCCK0_CCA not written to 0x83 on the second change. Explicitly initialize pre_cck_fa_state/cur_cck_fa_state in rtl_dm_diginit. Signed-off-by: Bernd Edlinger --- v2: Improved patch description. v3: Make the title fit in one line. --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 ++ drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c index 4bf7967..ce23339 100644 --- a/drivers/net/wireless/realtek/rtlwifi/core.c +++ b/drivers/net/wireless/realtek/rtlwifi/core.c @@ -1957,5 +1957,7 @@ void rtl_dm_diginit(struct ieee80211_hw *hw, u32 cur_igvalue) dm_digtable->bt30_cur_igi = 0x32; dm_digtable->pre_cck_pd_state = CCK_PD_STAGE_MAX; dm_digtable->cur_cck_pd_state = CCK_PD_STAGE_LOWRSSI; + dm_digtable->pre_cck_fa_state = 0; + dm_digtable->cur_cck_fa_state = 0; } EXPORT_SYMBOL(rtl_dm_diginit); diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c index 42a6fba..902b944 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c @@ -151,8 +151,14 @@ static u8 rtl8723e_dm_initial_gain_min_pwdb(struct ieee80211_hw *hw) { struct rtl_priv *rtlpriv = rtl_priv(hw); struct dig_t *dm_digtable = &rtlpriv->dm_digtable; + struct rtl_mac *mac = rtl_mac(rtlpriv); long rssi_val_min = 0; + if (mac->link_state == MAC80211_LINKED && + mac->opmode == NL80211_IFTYPE_STATION && + rtlpriv->link_info.bcn_rx_inperiod == 0) + return 0; + if ((dm_digtable->curmultista_cstate == DIG_MULTISTA_CONNECT) && (dm_digtable->cursta_cstate == DIG_STA_CONNECT)) { if (rtlpriv->dm.entry_min_undec_sm_pwdb != 0) @@ -417,6 +423,8 @@ static void rtl8723e_dm_cck_packet_detection_thresh(struct ieee80211_hw *hw) } else { rtl_set_bbreg(hw, RCCK0_CCA, MASKBYTE2, 0xcd); rtl_set_bbreg(hw, RCCK0_SYSTEM, MASKBYTE1, 0x47); + dm_digtable->pre_cck_fa_state = 0; + dm_digtable->cur_cck_fa_state = 0; } dm_digtable->pre_cck_pd_state = dm_digtable->cur_cck_pd_state;