| Message ID | CAJ3xEMhk+EQ_avGSBDB5_Gnj09w3goUJKkxzt8innWvFkTeEVA@mail.gmail.com |
|---|---|
| State | RFC |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | iproute2 DDMMYY versioning - why? | expand |
On Tue, 28 Jul 2020 16:05:50 +0300 Or Gerlitz wrote: > Stephen, > > Taking into account that iproute releases are aligned with the kernel > ones -- is there any real reason for the confusing DDMMYY double > versioning? > > I see that even the git tags go after the kernel releases.. +1
On Tue, 28 Jul 2020 16:05:50 +0300 Or Gerlitz <gerlitz.or@gmail.com> wrote: > Stephen, > > Taking into account that iproute releases are aligned with the kernel > ones -- is there any real reason for the confusing DDMMYY double > versioning? > > I see that even the git tags go after the kernel releases.. > > Or. > It is only an historical leftover, because 15 yrs ago that is how Alexy did it
On Tue, Jul 28, 2020 at 10:51 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
> It is only an historical leftover, because 15 yrs ago that is how Alexy did it
So how about putting behind the burden created by this historical leftover
and moving to use the kernel releases as the emitted version?
Or.
On Fri, 31 Jul 2020 16:23:06 +0300 Or Gerlitz <gerlitz.or@gmail.com> wrote: > On Tue, Jul 28, 2020 at 10:51 PM Stephen Hemminger > <stephen@networkplumber.org> wrote: > > > It is only an historical leftover, because 15 yrs ago that is how Alexy did it > > So how about putting behind the burden created by this historical leftover > and moving to use the kernel releases as the emitted version? The only downside to kernel versioning is the distros will think "can't use v5.10 because our kernel is still v4.3" and then want LTS versions of iproute2 which would create significant resource efforts. Open to changing to kernel versions, it would be trivial to do. The tagging and releases are by kernel version. The SNAPSHOT.h is autogenerated by a script, that can be changed.
diff --git a/include/SNAPSHOT.h b/include/SNAPSHOT.h index 0d10a9c2..0d211784 100644 --- a/include/SNAPSHOT.h +++ b/include/SNAPSHOT.h @@ -1 +1 @@ -static const char SNAPSHOT[] = "200330"; +static const char SNAPSHOT[] = "200602"; commit 29981db0e051cd4c53920c89dddcf3d883343a0f (tag: v5.6.0) Author: Stephen Hemminger <stephen@networkplumber.org> Date: Mon Mar 30 08:06:08 2020 -0700 v5.6.0 diff --git a/include/SNAPSHOT.h b/include/SNAPSHOT.h index c0fa1bb4..0d10a9c2 100644 --- a/include/SNAPSHOT.h +++ b/include/SNAPSHOT.h @@ -1 +1 @@ -static const char SNAPSHOT[] = "200127"; +static const char SNAPSHOT[] = "200330"; commit d4df55404aec707bd55c9264c666ddb1bb05d7f1 (tag: v5.5.0) Author: Stephen Hemminger <stephen@networkplumber.org> Date: Mon Jan 27 05:53:09 2020 -0800 v5.5.0 diff --git a/include/SNAPSHOT.h b/include/SNAPSHOT.h index b98ad502..c0fa1bb4 100644 --- a/include/SNAPSHOT.h +++ b/include/SNAPSHOT.h @@ -1 +1 @@ -static const char SNAPSHOT[] = "191125"; +static const char SNAPSHOT[] = "200127";
Stephen, Taking into account that iproute releases are aligned with the kernel ones -- is there any real reason for the confusing DDMMYY double versioning? I see that even the git tags go after the kernel releases.. Or. # git remote -v origin git://git.kernel.org/pub/scm/network/iproute2/iproute2.git (fetch) origin git://git.kernel.org/pub/scm/network/iproute2/iproute2.git (push) $ git log -p include/SNAPSHOT.h commit 1bfa3b3f66ef48bdabe0eb2a7c14e69f481dfa25 (tag: v5.7.0) Author: Stephen Hemminger <stephen@networkplumber.org> Date: Tue Jun 2 20:35:00 2020 -0700 v5.7.0 etc