| Message ID | 9dd553d458def04edc7790f0320ffdf1f8909aa5.1264201408.git.jan.kiszka@web.de |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, 10 Jan 2010 14:12:41 +0100 Jan Kiszka <jan.kiszka@web.de> wrote: > Despite all its bugs, the middleware support of our CAPI stack was > already in use for many, many moons. And after going through its code, > fixing all issues I found, I feel it deserves to officially become a > non-experimental feature. Slightly NAK this - I'm really glad to see the work getting done, but until it uses krefs properly for the tty references I'd say it is experimental still. I'd like to help you sort out the tty krefs stuff, using tty_port and so on and get that wart fixed too. Alan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan Cox wrote: > On Sun, 10 Jan 2010 14:12:41 +0100 > Jan Kiszka <jan.kiszka@web.de> wrote: > >> Despite all its bugs, the middleware support of our CAPI stack was >> already in use for many, many moons. And after going through its code, >> fixing all issues I found, I feel it deserves to officially become a >> non-experimental feature. > > Slightly NAK this - I'm really glad to see the work getting done, but > until it uses krefs properly for the tty references I'd say it is > experimental still. > > I'd like to help you sort out the tty krefs stuff, using tty_port and so > on and get that wart fixed too. Will look into to this. Some good starting point or reference driver for me? Thanks, Jan
On Sat, 23 Jan 2010 14:13:47 +0100 Jan Kiszka <jan.kiszka@web.de> wrote: > Alan Cox wrote: > > On Sun, 10 Jan 2010 14:12:41 +0100 > > Jan Kiszka <jan.kiszka@web.de> wrote: > > > >> Despite all its bugs, the middleware support of our CAPI stack was > >> already in use for many, many moons. And after going through its code, > >> fixing all issues I found, I feel it deserves to officially become a > >> non-experimental feature. > > > > Slightly NAK this - I'm really glad to see the work getting done, but > > until it uses krefs properly for the tty references I'd say it is > > experimental still. > > > > I'd like to help you sort out the tty krefs stuff, using tty_port and so > > on and get that wart fixed too. > > Will look into to this. Some good starting point or reference driver for me? Most of the drivers at least use tty_port and the tty_port ref counting helpers. The most full use of the new interfaces is probably the latest USB serial code and the drivers/mmc/card/sdio_uart.c code, which uses all the new facilities to the full to kick all the nasty open/close/hangup locking and logic out of the low level drivers. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/isdn/capi/Kconfig b/drivers/isdn/capi/Kconfig index b2a0475..66647ed 100644 --- a/drivers/isdn/capi/Kconfig +++ b/drivers/isdn/capi/Kconfig @@ -17,8 +17,7 @@ config CAPI_TRACE If unsure, say Y. config ISDN_CAPI_MIDDLEWARE - bool "CAPI2.0 Middleware support (EXPERIMENTAL)" - depends on EXPERIMENTAL + bool "CAPI2.0 Middleware support" help This option will enhance the capabilities of the /dev/capi20 interface. It will provide a means of moving a data connection,
Despite all its bugs, the middleware support of our CAPI stack was already in use for many, many moons. And after going through its code, fixing all issues I found, I feel it deserves to officially become a non-experimental feature. Signed-off-by: Jan Kiszka <jan.kiszka@web.de> --- drivers/isdn/capi/Kconfig | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)