From patchwork Fri Jan 13 20:27:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Ricardo Leitner X-Patchwork-Id: 715246 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v0Z2V0tDJz9vDk for ; Sat, 14 Jan 2017 07:28:16 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="S6v5fnJh"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751077AbdAMU2P (ORCPT ); Fri, 13 Jan 2017 15:28:15 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:34780 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbdAMU2O (ORCPT ); Fri, 13 Jan 2017 15:28:14 -0500 Received: by mail-qt0-f193.google.com with SMTP id a29so7584273qtb.1; Fri, 13 Jan 2017 12:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vChsYyjtxyXi2WDdzVWg17EdlIq/lFl3xDbNbrHGGEI=; b=S6v5fnJhoHoLWF4jlLsGhmIW1Uj0nU9JlgbP0bZ9XWuXYl+SoMOdPw+1dSNdxaRXyv qpPxdtyiVyKgwlfhnDVqYVQkde+1c5sGCldpguTKUBrzAKwRsjTw4mmDLHPCNoN5yzqt DqhCa5NfZBV9KVBLjo0GWtHK7gpbEa2i4p1A/C/TQNF1d0Ccip5lmXqJtbShXSeZC/ER X1Y8XVZHXzMP3wA3OLNPBLhtuQK8vqhqY6rcaDzpSv4FLV6TTAysmfJmxF+RcbGgN+2M NLWZTvjf1gZZVR0TtRj07CS0WkuLz99cYuFly4aiYdF/ZffnjO28gquxW8bF/UkHqDFR QRzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vChsYyjtxyXi2WDdzVWg17EdlIq/lFl3xDbNbrHGGEI=; b=aexoBBJR/DRPSKevKLzjvd+1KSFvQ88zE5sOJlgCiQLC1PSQFV69og/n2lOnSmkH+k 7Re7JjoUB13OsHqHHrgHoMYgQn60G8uWYQbnhXJXcZ0PAhgmldo2sBrDh3asRxDmIrfx 3onasGOQaVDZoRa5olut1IiNMevQ56UafRsSn/LDj1828jzfraytHAoKXtcVhiUw1kcS 7/5s/fedlKNkl6Z7MQkyxutGCAqQT2wY9xb1mKydVE43cuDKiEeJSda2XLdfvHN/QhQ3 BAqkZaZxElYqgMCo2XWTSIfZzh/FpCEaXOBsDxHDxgaBpe1nDipQ4oyW1RAw98hJtI8c pMSg== X-Gm-Message-State: AIkVDXIdIUYnDVJVi13Teo9gK/kcfWZ7PRi1VVWWmw7t4TonHvjgXAmR/034AEIheMmxDA== X-Received: by 10.200.46.110 with SMTP id s43mr19112029qta.225.1484339293877; Fri, 13 Jan 2017 12:28:13 -0800 (PST) Received: from localhost.localdomain.com ([2001:1284:f003:cb6a:9cbc:f8f3:3354:efcf]) by smtp.gmail.com with ESMTPSA id w75sm906804qkb.26.2017.01.13.12.28.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jan 2017 12:28:13 -0800 (PST) From: Marcelo Ricardo Leitner To: netdev@vger.kernel.org Cc: linux-sctp@vger.kernel.org, Vlad Yasevich , Neil Horman Subject: [PATCH net-next] sctp: remove dead code from sctp_apply_peer_addr_params Date: Fri, 13 Jan 2017 18:27:32 -0200 Message-Id: <99bc9f227c4c857d2bb25839a6a8341d46c1899d.1484336556.git.marcelo.leitner@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org sctp_frag_point() doesn't store anything, and thus just calling it cannot do anything useful. sctp_apply_peer_addr_params is only called by sctp_setsockopt_peer_addr_params. When operating on an asoc, sctp_setsockopt_peer_addr_params will call sctp_apply_peer_addr_params once for the asoc, and then once for each transport this asoc has, meaning that the frag_point will be recomputed when updating the transports and calling it when updating the asoc is not necessary. IOW, no action is needed here and we can remove this call. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/socket.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 318c6786d6539a301ac7b76d82a49a1af3818d10..635e0341269330187c78ba93a35689f5c5d6be02 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -2430,7 +2430,6 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params, sctp_assoc_sync_pmtu(sctp_opt2sk(sp), asoc); } else if (asoc) { asoc->pathmtu = params->spp_pathmtu; - sctp_frag_point(asoc, params->spp_pathmtu); } else { sp->pathmtu = params->spp_pathmtu; }