From patchwork Fri Jan 13 20:31:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Ricardo Leitner X-Patchwork-Id: 715248 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v0Z6j41Dbz9vDk for ; Sat, 14 Jan 2017 07:31:57 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Sy/daA2K"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751117AbdAMUbz (ORCPT ); Fri, 13 Jan 2017 15:31:55 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:35109 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbdAMUby (ORCPT ); Fri, 13 Jan 2017 15:31:54 -0500 Received: by mail-qt0-f195.google.com with SMTP id f4so7583792qte.2; Fri, 13 Jan 2017 12:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vChsYyjtxyXi2WDdzVWg17EdlIq/lFl3xDbNbrHGGEI=; b=Sy/daA2K2RjVGRTtHr1+JENW0CAp9yEKwlKlhFXSyEuxbPrRN21AFRakYpRrLsR85n IsQ+duq9iWMUJGlW5qcj80w/miN5t47IekEsW8aYTAH8XkNAL1iFkX6sG3v6blosO5bl RFvnDX5OcxJZrXayR//PzRWoyTJN1h96ikh4lAfI/W2tB+ZZxxyipoZfQunCDbGN8nX8 JcFQWX7PJUngU7UXWIhmlCutVfvJ5V5kreLGdxu44zkePsLJUa/LZPM12Uy62yvS3zLY lWdX+HxdNB8vyeVmY23RtSYfcmsIdxAxnZCyH+Afads+lq1cQfqd5tRr+mmiLHDLhmt+ oXfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vChsYyjtxyXi2WDdzVWg17EdlIq/lFl3xDbNbrHGGEI=; b=tl1vugKJeIwbTZc6ZDLYLcFEGM/dnCBDkYpYNjE0SE1QEEvHROA2KDhaSjw3BuMeLh ymCyzLV+EGss7hmRwp5RBhOIAjgClMBXk8gomr5hqeZZNRO29vz1KEn4wNyHGP56KppX nleJ1yR4Tzo8Rdg5Upi8QsKAXWbNGHC0Xb78yfBh6X1u2flhbH8TbZHmbYwL7844+A3o uH2jU0UDsuDQvKVuE4HBzow68yVEJy7UW3YpgHkFZnV7PVekeWsfWIY1OArktEEQTR1m JIF2K7rslhe8H4yPdeWIzt30Uho4GSejTnqb88EXHC+t/kI/aeUHVJRuWrVltSQsUT8u fcwA== X-Gm-Message-State: AIkVDXL3eojzzFbpToqYSq+SG6OCoIZ2UQzqhGAU+doMqC5YJjmBISCH+vGuniZunX+cTw== X-Received: by 10.200.38.168 with SMTP id 37mr19074636qto.160.1484339513083; Fri, 13 Jan 2017 12:31:53 -0800 (PST) Received: from localhost.localdomain.com ([2001:1284:f003:cb6a:9cbc:f8f3:3354:efcf]) by smtp.gmail.com with ESMTPSA id e33sm9964697qtb.31.2017.01.13.12.31.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jan 2017 12:31:52 -0800 (PST) From: Marcelo Ricardo Leitner To: netdev@vger.kernel.org Cc: linux-sctp@vger.kernel.org, Vlad Yasevich , Neil Horman Subject: [PATCH net-next] sctp: remove useless code from sctp_apply_peer_addr_params Date: Fri, 13 Jan 2017 18:31:15 -0200 Message-Id: <99bc9f227c4c857d2bb258391231231d46c1899d.1484336556.git.marcelo.leitner@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org sctp_frag_point() doesn't store anything, and thus just calling it cannot do anything useful. sctp_apply_peer_addr_params is only called by sctp_setsockopt_peer_addr_params. When operating on an asoc, sctp_setsockopt_peer_addr_params will call sctp_apply_peer_addr_params once for the asoc, and then once for each transport this asoc has, meaning that the frag_point will be recomputed when updating the transports and calling it when updating the asoc is not necessary. IOW, no action is needed here and we can remove this call. Signed-off-by: Marcelo Ricardo Leitner Acked-by: Neil Horman Reviewed-by: Xin Long --- net/sctp/socket.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 318c6786d6539a301ac7b76d82a49a1af3818d10..635e0341269330187c78ba93a35689f5c5d6be02 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -2430,7 +2430,6 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params, sctp_assoc_sync_pmtu(sctp_opt2sk(sp), asoc); } else if (asoc) { asoc->pathmtu = params->spp_pathmtu; - sctp_frag_point(asoc, params->spp_pathmtu); } else { sp->pathmtu = params->spp_pathmtu; }