From patchwork Sun Mar 16 13:29:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Cochran X-Patchwork-Id: 330697 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C2B0F2C009E for ; Mon, 17 Mar 2014 00:33:24 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753734AbaCPNbD (ORCPT ); Sun, 16 Mar 2014 09:31:03 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:45681 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbaCPNaF (ORCPT ); Sun, 16 Mar 2014 09:30:05 -0400 Received: by mail-ee0-f53.google.com with SMTP id b57so2502916eek.12 for ; Sun, 16 Mar 2014 06:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=azxj8Zs/yhDCKXs4pjMOtSBuNXqApY1Hg3jEx/zlGmo=; b=au7jpEbOdGMaeNXVTGkCD5DrKxUVm21m1/W3ht4vQsFJRTWRXT5JV+5k8K0VH8lAtY 9XCO37HeBVSbbn7Bz3P5gJO5PU3SVRhIhcNkJS7/z4U4NeI7EY5huSTvq9MHCNqCO9tx yM9pT2Uv8wbN/cg3gALjYuRr5u4chlMKFHke/80quuqRzocpLdqHq5t99ndmr1s1N5K4 G8uGfrF1h0QMI2YJugi3JOtrehurs07SXbzyeczYJqaIL/fGBCGTA/cq8N2VzeyOIH1R wWxWoSGhae9YJiHt8iFWCIcPKY4bx3cO4GFJzvKgGK5eZUtpIvS3iyxz6Fm4YJ3hrnA1 rloA== X-Received: by 10.15.27.195 with SMTP id p43mr18775928eeu.2.1394976604675; Sun, 16 Mar 2014 06:30:04 -0700 (PDT) Received: from localhost.localdomain (089144223122.atnat0032.highway.bob.at. [89.144.223.122]) by mx.google.com with ESMTPSA id o5sm32161097eeg.8.2014.03.16.06.30.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Mar 2014 06:30:04 -0700 (PDT) From: Richard Cochran To: Cc: , Ben Hutchings , Christian Riesch , David Miller , =?UTF-8?q?Stefan=20S=C3=B8rensen?= Subject: [PATCH net-next v2 5/9] dp83640: trivial fixes Date: Sun, 16 Mar 2014 14:29:26 +0100 Message-Id: <91de995709abdb2c689eb5adcfa6c90606589c32.1394975663.git.richardcochran@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch cleans up the input checking code on the external time stamp function by using an unsigned rather than a signed channel index. Also, this patch corrects the author's email address. When this macro was last changed, the top level domain part of the email address was left behind. Signed-off-by: Richard Cochran --- drivers/net/phy/dp83640.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 98e7cbf..d6c1061 100644 --- a/drivers/net/phy/dp83640.c +++ b/drivers/net/phy/dp83640.c @@ -424,13 +424,13 @@ static int ptp_dp83640_enable(struct ptp_clock_info *ptp, struct dp83640_clock *clock = container_of(ptp, struct dp83640_clock, caps); struct phy_device *phydev = clock->chosen->phydev; - int index; + unsigned int index; u16 evnt, event_num, gpio_num; switch (rq->type) { case PTP_CLK_REQ_EXTTS: index = rq->extts.index; - if (index < 0 || index >= N_EXT_TS) + if (index >= N_EXT_TS) return -EINVAL; event_num = EXT_EVENT + index; evnt = EVNT_WR | (event_num & EVNT_SEL_MASK) << EVNT_SEL_SHIFT; @@ -1363,7 +1363,7 @@ static void __exit dp83640_exit(void) } MODULE_DESCRIPTION("National Semiconductor DP83640 PHY driver"); -MODULE_AUTHOR("Richard Cochran "); +MODULE_AUTHOR("Richard Cochran "); MODULE_LICENSE("GPL"); module_init(dp83640_init);