| Message ID | 8aa55fa1-5ba6-2f65-e651-463fe3bed303@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] r8169: fix rtl_hw_jumbo_disable for RTL8168evl | expand |
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Fri, 6 Dec 2019 22:55:00 +0100 > Fixes: c07fd3caadc3 ("r8169: fix jumbo configuration for RTL8168evl") [davem@localhost net]$ git describe c07fd3caadc3 fatal: Not a valid object name c07fd3caadc3 [davem@localhost net]$
On 07.12.2019 21:01, David Miller wrote: > From: Heiner Kallweit <hkallweit1@gmail.com> > Date: Fri, 6 Dec 2019 22:55:00 +0100 > >> Fixes: c07fd3caadc3 ("r8169: fix jumbo configuration for RTL8168evl") > > [davem@localhost net]$ git describe c07fd3caadc3 > fatal: Not a valid object name c07fd3caadc3 > [davem@localhost net]$ > My bad, this refers to the commit in 5.4 tree. I'll resubmit.
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 38d212686..46a492229 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -3896,7 +3896,7 @@ static void rtl_hw_jumbo_disable(struct rtl8169_private *tp) case RTL_GIGA_MAC_VER_27 ... RTL_GIGA_MAC_VER_28: r8168dp_hw_jumbo_disable(tp); break; - case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_34: + case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33: r8168e_hw_jumbo_disable(tp); break; default:
In referenced fix we removed the RTL8168e-specific jumbo config for RTL8168evl in rtl_hw_jumbo_enable(). We have to do the same in rtl_hw_jumbo_disable(). Fixes: c07fd3caadc3 ("r8169: fix jumbo configuration for RTL8168evl") Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)