| Message ID | 65a0791a760dc488f62445343e041baf4a2db17e.1540204183.git.joabreu@synopsys.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: Misc improvements for Generic 10G PHY | expand |
On Mon, Oct 22, 2018 at 11:32:47AM +0100, Jose Abreu wrote: > We already have this callback implemented. Use it in driver structure. > > Signed-off-by: Jose Abreu <joabreu@synopsys.com> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Joao Pinto <joao.pinto@synopsys.com> > --- > drivers/net/phy/phy-c45.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c > index e1225545362d..c0135217b81f 100644 > --- a/drivers/net/phy/phy-c45.c > +++ b/drivers/net/phy/phy-c45.c > @@ -330,6 +330,7 @@ struct phy_driver genphy_10g_driver = { > .soft_reset = gen10g_no_soft_reset, > .config_init = gen10g_config_init, > .features = 0, > + .aneg_done = genphy_c45_aneg_done, > .config_aneg = gen10g_config_aneg, > .read_status = gen10g_read_status, > .suspend = gen10g_suspend, We should probably do something about the naming. I need to look at the history to understand why we have gen10g_ and genphy_c45_. Andrew
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index e1225545362d..c0135217b81f 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -330,6 +330,7 @@ struct phy_driver genphy_10g_driver = { .soft_reset = gen10g_no_soft_reset, .config_init = gen10g_config_init, .features = 0, + .aneg_done = genphy_c45_aneg_done, .config_aneg = gen10g_config_aneg, .read_status = gen10g_read_status, .suspend = gen10g_suspend,
We already have this callback implemented. Use it in driver structure. Signed-off-by: Jose Abreu <joabreu@synopsys.com> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Joao Pinto <joao.pinto@synopsys.com> --- drivers/net/phy/phy-c45.c | 1 + 1 file changed, 1 insertion(+)