diff mbox series

mdio: fix mdio-thunder.c dependency & build error

Message ID 5aecbd3f-a489-0738-8249-5e08a6f2766f@infradead.org
State Accepted
Delegated to: David Miller
Headers show
Series mdio: fix mdio-thunder.c dependency & build error | expand

Commit Message

Randy Dunlap Sept. 27, 2020, 4:33 a.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix build error by selecting MDIO_DEVRES for MDIO_THUNDER.
Fixes this build error:

ld: drivers/net/phy/mdio-thunder.o: in function `thunder_mdiobus_pci_probe':
drivers/net/phy/mdio-thunder.c:78: undefined reference to `devm_mdiobus_alloc_size'

Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: netdev@vger.kernel.org
Cc: David Daney <david.daney@cavium.com>
---
or applies to drivers/net/phy/Kconfig in mainline (or stable) # v4.6

 drivers/net/mdio/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Lunn Sept. 27, 2020, 3:08 p.m. UTC | #1 
On Sat, Sep 26, 2020 at 09:33:43PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build error by selecting MDIO_DEVRES for MDIO_THUNDER.
> Fixes this build error:
> 
> ld: drivers/net/phy/mdio-thunder.o: in function `thunder_mdiobus_pci_probe':
> drivers/net/phy/mdio-thunder.c:78: undefined reference to `devm_mdiobus_alloc_size'
> 
> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
David Miller Sept. 27, 2020, 8:23 p.m. UTC | #2 
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 26 Sep 2020 21:33:43 -0700

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build error by selecting MDIO_DEVRES for MDIO_THUNDER.
> Fixes this build error:
> 
> ld: drivers/net/phy/mdio-thunder.o: in function `thunder_mdiobus_pci_probe':
> drivers/net/phy/mdio-thunder.c:78: undefined reference to `devm_mdiobus_alloc_size'
> 
> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied to 'net' and queued up for -stable, thanks.
diff mbox series

Patch

--- linux-next-20200925.orig/drivers/net/mdio/Kconfig
+++ linux-next-20200925/drivers/net/mdio/Kconfig
@@ -164,6 +164,7 @@  config MDIO_THUNDER
 	depends on 64BIT
 	depends on PCI
 	select MDIO_CAVIUM
+	select MDIO_DEVRES
 	help
 	  This driver supports the MDIO interfaces found on Cavium
 	  ThunderX SoCs when the MDIO bus device appears as a PCI