| Message ID | 573e5947-3a12-f69d-d1b3-1b0d1c49f367@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] Revert "r8169: remove not needed call to dma_sync_single_for_device" | expand |
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Fri, 23 Aug 2019 19:57:49 +0200 > This reverts commit f072218cca5b076dd99f3dfa3aaafedfd0023a51. > > As reported by Aaro this patch causes network problems on > MIPS Loongson platform. Therefore revert it. > > Fixes: f072218cca5b ("r8169: remove not needed call to dma_sync_single_for_device") > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi> Applied.
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index e1dd6ea60..bae0074ab 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5921,6 +5921,7 @@ static struct sk_buff *rtl8169_try_rx_copy(void *data, skb = napi_alloc_skb(&tp->napi, pkt_size); if (skb) skb_copy_to_linear_data(skb, data, pkt_size); + dma_sync_single_for_device(d, addr, pkt_size, DMA_FROM_DEVICE); return skb; }
This reverts commit f072218cca5b076dd99f3dfa3aaafedfd0023a51. As reported by Aaro this patch causes network problems on MIPS Loongson platform. Therefore revert it. Fixes: f072218cca5b ("r8169: remove not needed call to dma_sync_single_for_device") Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi> --- This fix doesn't apply cleanly on net-next, I'll provide a separate one for net-next. --- drivers/net/ethernet/realtek/r8169_main.c | 1 + 1 file changed, 1 insertion(+)