| Message ID | 546c6d2f-39ca-521d-7009-d80df735bd9e@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func | expand |
On 6/5/19 3:49 AM, Zhiqiang Liu wrote: > small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink > func is never used in the func, so we can remove it. > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> > --- SGTM Reviewed-by: Eric Dumazet <edumazet@google.com>
From: Zhiqiang Liu <liuzhiqiang26@huawei.com> Date: Wed, 5 Jun 2019 18:49:49 +0800 > small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink > func is never used in the func, so we can remove it. > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> Applied, thanks.
> From: Zhiqiang Liu <liuzhiqiang26@huawei.com> > Date: Wed, 5 Jun 2019 18:49:49 +0800 > >> small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink >> func is never used in the func, so we can remove it. >> >> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> > > Applied, thanks. > Hi, David Miller. So sorry for forgetting to sign partner's name who find the cleanup together. I have sent v2 patch with my partner's signature. I am so sorry for the mistake.
From: Zhiqiang Liu <liuzhiqiang26@huawei.com> Date: Thu, 6 Jun 2019 10:06:55 +0800 >> From: Zhiqiang Liu <liuzhiqiang26@huawei.com> >> Date: Wed, 5 Jun 2019 18:49:49 +0800 >> >>> small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink >>> func is never used in the func, so we can remove it. >>> >>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> >> >> Applied, thanks. >> > > Hi, David Miller. > So sorry for forgetting to sign partner's name who find the cleanup together. > I have sent v2 patch with my partner's signature. > > I am so sorry for the mistake. It is already pushed out to my public GIT tree and the commit is immutable.
>>>> small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink >>>> func is never used in the func, so we can remove it. >>>> >>>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> >>> >>> Applied, thanks. >>> >> >> Hi, David Miller. >> So sorry for forgetting to sign partner's name who find the cleanup together. >> I have sent v2 patch with my partner's signature. >> >> I am so sorry for the mistake. > > It is already pushed out to my public GIT tree and the commit is immutable. > Ok, I'll pay more attention next time. Sorry again.
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index 6ea523d71947..632855a8abb3 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -653,8 +653,7 @@ int inet_rtx_syn_ack(const struct sock *parent, struct request_sock *req) EXPORT_SYMBOL(inet_rtx_syn_ack); /* return true if req was found in the ehash table */ -static bool reqsk_queue_unlink(struct request_sock_queue *queue, - struct request_sock *req) +static bool reqsk_queue_unlink(struct request_sock *req) { struct inet_hashinfo *hashinfo = req_to_sk(req)->sk_prot->h.hashinfo; bool found = false; @@ -673,7 +672,7 @@ static bool reqsk_queue_unlink(struct request_sock_queue *queue, void inet_csk_reqsk_queue_drop(struct sock *sk, struct request_sock *req) { - if (reqsk_queue_unlink(&inet_csk(sk)->icsk_accept_queue, req)) { + if (reqsk_queue_unlink(req)) { reqsk_queue_removed(&inet_csk(sk)->icsk_accept_queue, req); reqsk_put(req); }
small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink func is never used in the func, so we can remove it. Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> --- net/ipv4/inet_connection_sock.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --