From patchwork Thu Sep 3 12:03:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 32881 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id F268DB7093 for ; Thu, 3 Sep 2009 22:03:35 +1000 (EST) Received: by ozlabs.org (Postfix) id E12D9DDD0B; Thu, 3 Sep 2009 22:03:35 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id D87D6DDD04 for ; Thu, 3 Sep 2009 22:03:34 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754711AbZICMDV (ORCPT ); Thu, 3 Sep 2009 08:03:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754332AbZICMDV (ORCPT ); Thu, 3 Sep 2009 08:03:21 -0400 Received: from gw1.cosmosbay.com ([212.99.114.194]:60618 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbZICMDU (ORCPT ); Thu, 3 Sep 2009 08:03:20 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by gw1.cosmosbay.com (8.13.7/8.13.7) with ESMTP id n83C38a7027985; Thu, 3 Sep 2009 14:03:09 +0200 Message-ID: <4A9FB07D.5000509@gmail.com> Date: Thu, 03 Sep 2009 14:03:09 +0200 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Jiri Pirko CC: "David S. Miller" , Linux Netdev List Subject: Re: [PATCH net-next-2.6] net: net/core/dev.c cleanups References: <4A9F7BFC.5000401@gmail.com> <20090903115026.GD2885@psychotron.lab.eng.brq.redhat.com> In-Reply-To: <20090903115026.GD2885@psychotron.lab.eng.brq.redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Thu, 03 Sep 2009 14:03:09 +0200 (CEST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jiri Pirko a écrit : > Hmm, this patch causes following warnings for me: > > eth%d dev=ffff88007b9dc000 queue_count=1 tx=ffff88007c565e00 Oops ! Sorry, I left a debugging aid :( Thanks Jiri [PATCH net-next-2.6] net: Remove debugging code Remove a debugging aid I accidently left in previous 'cleanup' patch Signed-off-by: Eric Dumazet --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/dev.c b/net/core/dev.c index dd94ae6..1a6561b 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5155,8 +5155,6 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name, } dev = PTR_ALIGN(p, NETDEV_ALIGN); - pr_err("%s dev=%p queue_count=%d tx=%p\n", name, dev, queue_count, tx); - WARN_ON(queue_count == 1); dev->padded = (char *)dev - (char *)p; if (dev_addr_init(dev))