| Message ID | 4A702A02.30509@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Roel Kluin wrote, On 07/29/2009 12:52 PM: > If arp_format_neigh_entry() can be called with n->dev->addr_len == 0, then a > write to hbuffer[-1] occurs. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > Found with Parfait, http://research.sun.com/projects/parfait/ > > It's not clear whether this can happen or not. > > diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c > index c29d75d..252336f 100644 > --- a/net/ipv4/arp.c > +++ b/net/ipv4/arp.c > @@ -1304,7 +1304,8 @@ static void arp_format_neigh_entry(struct seq_file *seq, > hbuffer[k++] = hex_asc_lo(n->ha[j]); > hbuffer[k++] = ':'; > } > - hbuffer[--k] = 0; > + if (k != 0) > + hbuffer[--k] = 0; I guess for k == 0 we need hbuffer[0] = 0 too. Jarek P. > #if defined(CONFIG_AX25) || defined(CONFIG_AX25_MODULE) > } > #endif > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index c29d75d..252336f 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -1304,7 +1304,8 @@ static void arp_format_neigh_entry(struct seq_file *seq, hbuffer[k++] = hex_asc_lo(n->ha[j]); hbuffer[k++] = ':'; } - hbuffer[--k] = 0; + if (k != 0) + hbuffer[--k] = 0; #if defined(CONFIG_AX25) || defined(CONFIG_AX25_MODULE) } #endif
If arp_format_neigh_entry() can be called with n->dev->addr_len == 0, then a write to hbuffer[-1] occurs. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- Found with Parfait, http://research.sun.com/projects/parfait/ It's not clear whether this can happen or not. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html