diff mbox

[IPROUTE] : Refuse "ip link add/replace" without device type parameter

Message ID 48EB7D4B.4030501@trash.net
State Not Applicable, archived
Headers show

Commit Message

Patrick McHardy Oct. 7, 2008, 3:16 p.m. UTC
diff mbox

Patch

commit c3ae059edf3316cff1075c2401bdeefa5e262251
Author: Patrick McHardy <kaber@trash.net>
Date:   Tue Oct 7 16:55:21 2008 +0200

    [IPROUTE]: Refuse "ip link add/replace" without device type parameter
    
    Fix confusing error message noticed by Martin Josefsson:
    
    # ip link add
    RTNETLINK answers: Operation not supported
    
    The reason is missing device type information, refuse this and print a message.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>

diff --git a/ip/iplink.c b/ip/iplink.c
index 81122ae..6e9ac71 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -336,6 +336,10 @@  static int iplink_modify(int cmd, unsigned int flags, int argc, char **argv)
 			return -1;
 		}
 		linkinfo->rta_len = (void *)NLMSG_TAIL(&req.n) - (void *)linkinfo;
+	} else if (flags & NLM_F_CREATE) {
+		fprintf(stderr, "Not enough informatin: \"type\" argument "
+				"is required\n");
+		return -1;
 	}
 
 	if (!(flags & NLM_F_CREATE)) {