From patchwork Thu Apr 26 19:58:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Ricardo Leitner X-Patchwork-Id: 905364 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LCbW1NxH"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40X7Mk3Nljz9s02 for ; Fri, 27 Apr 2018 06:05:06 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756690AbeDZUFE (ORCPT ); Thu, 26 Apr 2018 16:05:04 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:35000 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754568AbeDZT7Y (ORCPT ); Thu, 26 Apr 2018 15:59:24 -0400 Received: by mail-qt0-f193.google.com with SMTP id s2-v6so33192331qti.2; Thu, 26 Apr 2018 12:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1poztdlE6w8+puq4AClTP7WgDLDWE34KFv0fYiu4kF0=; b=LCbW1NxHI3bw+MZT2aJom/3ExmhFd/BeuulROtNeiCFKNh1YuXrb7JFiSBjJViXNIG rTpx4ydx2lqEgUtlcha/RadNX0RRXGfjzxAblbarQnsCNGBnjZEb8Jt8a4jmKBpBIkeP GgTwbRtMquoYMjm8HHPnuUkuuaKWONaOEpgUaiXqtbbe2VK6ChfitCU0oTY58gXoymj+ VgIB3lto+VTRvfuQrkGF5kG9qKt6Aun0PFxjvuDGwceWnXGRKxwmh5d33EQ2FYkKgNok Dk7UYHd0zzT58pBO6WgSr+wbu6GAUi0YJCqOAlpf8VlKguViVTjoi+uGYqAett4uBGbm R2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1poztdlE6w8+puq4AClTP7WgDLDWE34KFv0fYiu4kF0=; b=Di9jQLYjlpKvi7fXERkY4yj/2NUkJL1R9CIO2QO08GQzviu45Uq/7DPQPAjbIFGHI4 FPtS1vpaHO0RzCgpdZ7UpnFJu8eD38Y2RdH2GqDBVd13lsrMwLF9uMw6TXisPz43uVqD r2sV0S+DNwc1sm/Si59KnOb/T8U/UbE7b8TnCKVk/2W18Tu31fqik9LI8SYF2zwfhFZ7 LDvpaFHoLYRHMUiCfo4LlrnabqpvvQFNnqISKAxqoq+NDYdD5HXhO5GYJucg8+LkBDAQ klPAbs8jmM+E+Jt6B+Xa3Y4/F0sCO+EyU7pjhr0mU8OYuITOWbaoU62Nsn0kKyXWpca5 vCvg== X-Gm-Message-State: ALQs6tDi1HubGnpJu4gWrza6BFm+V6AtPy3XcrAz38A7gcHIC8lS/7x3 QLU5930b7s4g3Ig5jjUXNsk= X-Google-Smtp-Source: AB8JxZrv++MDaYw+PF6PQlx9cifeffH+DLivdJw2gevS8MKGyyeuBSDOLfyMGX06DSfxNiSIyHTCDg== X-Received: by 2002:ac8:e8a:: with SMTP id v10-v6mr37816115qti.376.1524772763748; Thu, 26 Apr 2018 12:59:23 -0700 (PDT) Received: from localhost.localdomain ([177.10.56.95]) by smtp.gmail.com with ESMTPSA id u24sm1086481qku.18.2018.04.26.12.59.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 12:59:22 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 9B2E51808B4; Thu, 26 Apr 2018 16:59:18 -0300 (-03) From: Marcelo Ricardo Leitner To: netdev@vger.kernel.org Cc: linux-sctp@vger.kernel.org, Vlad Yasevich , Neil Horman , Xin Long Subject: [PATCH net-next 01/13] sctp: remove old and unused SCTP_MIN_PMTU Date: Thu, 26 Apr 2018 16:58:50 -0300 Message-Id: <3959797f9a87225ae154a9d3f81cae4fd10f01a1.1524772453.git.marcelo.leitner@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This value is not used anywhere in the code. In essence it is a duplicate of SCTP_DEFAULT_MINSEGMENT, which is used by the stack. SCTP_MIN_PMTU value makes more sense, but we should not change to it now as it would risk breaking applications. So this patch removes SCTP_MIN_PMTU and adjust the comment above it. Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/constants.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/net/sctp/constants.h b/include/net/sctp/constants.h index 20ff237c5eb2ff358589b30bbd89d636e41b2d92..86f034b524d46178e4d26e868be3a2bf87acac4a 100644 --- a/include/net/sctp/constants.h +++ b/include/net/sctp/constants.h @@ -254,11 +254,10 @@ enum { SCTP_ARBITRARY_COOKIE_ECHO_LEN = 200 }; #define SCTP_TSN_MAP_SIZE 4096 /* We will not record more than this many duplicate TSNs between two - * SACKs. The minimum PMTU is 576. Remove all the headers and there - * is enough room for 131 duplicate reports. Round down to the + * SACKs. The minimum PMTU is 512. Remove all the headers and there + * is enough room for 117 duplicate reports. Round down to the * nearest power of 2. */ -enum { SCTP_MIN_PMTU = 576 }; enum { SCTP_MAX_DUP_TSNS = 16 }; enum { SCTP_MAX_GABS = 16 };