| Message ID | 300158ea936857419218a1cbab788dc72ccf349a.1521226621.git.marcelo.leitner@gmail.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | Add support for warnings to extack | expand |
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index e828d31be5dae0ae8c69016dfde50379296484aa..7cec393bb47974b48a6d510b8aa84534a7a98594 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -705,8 +705,7 @@ tc_cls_common_offload_init(struct tc_cls_common_offload *cls_common, cls_common->chain_index = tp->chain->index; cls_common->protocol = tp->protocol; cls_common->prio = tp->prio; - if (tc_skip_sw(flags)) - cls_common->extack = extack; + cls_common->extack = extack; } enum tc_fl_command {
Currently, when the rule is not to be exclusively executed by the hardware, extack is not passed along. The idea was that hardware failures are okay because the rule will get executed in software then. This is not helpful in case one needs to understand why a certain rule failed to get offloaded. Considering it may have been a temporary failure, like resources exceeded or so, reproducing it later and knowing it is triggering the same reason may be challenging. This patch thus removes the condition and makes it always pass extack structure along. Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> --- include/net/pkt_cls.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)