| Message ID | 2c4f254c-6b17-714e-81e2-96bb6b08a12d@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: phy: realtek: fix using paged operations with RTL8105e / RTL8208 | expand |
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Sun, 1 Dec 2019 10:51:47 +0100 > It was reported [0] that since the referenced commit a warning is > triggered in phylib that complains about paged operations being used > with a PHY driver that doesn't support this. The commit isn't wrong, > just for one chip version (RTL8105e) no dedicated PHY driver exists > yet. So add the missing PHY driver. > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=202103 > > Fixes: 3a129e3f9ac4 ("r8169: switch to phylib functions in more places") > Reported-by: jhdskag3 <jhdskag3@tutanota.com> > Tested-by: jhdskag3 <jhdskag3@tutanota.com> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied.
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 677c45985..476db5345 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -439,6 +439,15 @@ static struct phy_driver realtek_drvs[] = { .resume = genphy_resume, .read_page = rtl821x_read_page, .write_page = rtl821x_write_page, + }, { + PHY_ID_MATCH_MODEL(0x001cc880), + .name = "RTL8208 Fast Ethernet", + .read_mmd = genphy_read_mmd_unsupported, + .write_mmd = genphy_write_mmd_unsupported, + .suspend = genphy_suspend, + .resume = genphy_resume, + .read_page = rtl821x_read_page, + .write_page = rtl821x_write_page, }, { PHY_ID_MATCH_EXACT(0x001cc910), .name = "RTL8211 Gigabit Ethernet",
It was reported [0] that since the referenced commit a warning is triggered in phylib that complains about paged operations being used with a PHY driver that doesn't support this. The commit isn't wrong, just for one chip version (RTL8105e) no dedicated PHY driver exists yet. So add the missing PHY driver. [0] https://bugzilla.kernel.org/show_bug.cgi?id=202103 Fixes: 3a129e3f9ac4 ("r8169: switch to phylib functions in more places") Reported-by: jhdskag3 <jhdskag3@tutanota.com> Tested-by: jhdskag3 <jhdskag3@tutanota.com> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/realtek.c | 9 +++++++++ 1 file changed, 9 insertions(+)