diff mbox series

[2/2] can: kvaser_pciefd: Fix error handling in kvaser_pciefd_open

Message ID 20201128133922.3276973-3-zhangqilong3@huawei.com
State Superseded
Headers show
Series can: Fix the error handling in c_can_power_up and kvaser_pciefd_open | expand

Commit Message

Zhang Qilong Nov. 28, 2020, 1:39 p.m. UTC 
If kvaser_pciefd_bus_on failed, we should call close_candev
to avoid reference leak.

Fixes: 26ad340e582d3 ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 drivers/net/can/kvaser_pciefd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
index 1bafa614950e..969cedb9b0b6 100644
--- a/drivers/net/can/kvaser_pciefd.c
+++ b/drivers/net/can/kvaser_pciefd.c
@@ -692,8 +692,10 @@  static int kvaser_pciefd_open(struct net_device *netdev)
 		return err;
 
 	err = kvaser_pciefd_bus_on(can);
-	if (err)
+	if (err) {
+		close_candev(netdev);
 		return err;
+	}
 
 	return 0;
 }