| Message ID | 20201114115223.39505-1-wanghai38@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net] net/mlx5: fix error return code in mlx5e_tc_nic_init() | expand |
On Sat, 2020-11-14 at 19:52 +0800, Wang Hai wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic > flows") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wang Hai <wanghai38@huawei.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > index e3a968e9e2a0..c7ad5db84f78 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > @@ -5227,8 +5227,10 @@ int mlx5e_tc_nic_init(struct mlx5e_priv *priv) > > tc->ct = mlx5_tc_ct_init(priv, tc->chains, &priv- > >fs.tc.mod_hdr, > MLX5_FLOW_NAMESPACE_KERNEL); > - if (IS_ERR(tc->ct)) > + if (IS_ERR(tc->ct)) { > + err = PTR_ERR(tc->ct); > goto err_ct; > + } > > tc->netdevice_nb.notifier_call = mlx5e_tc_netdev_event; > err = register_netdevice_notifier_dev_net(priv->netdev, Applied to net-mlx5 Thanks !
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index e3a968e9e2a0..c7ad5db84f78 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -5227,8 +5227,10 @@ int mlx5e_tc_nic_init(struct mlx5e_priv *priv) tc->ct = mlx5_tc_ct_init(priv, tc->chains, &priv->fs.tc.mod_hdr, MLX5_FLOW_NAMESPACE_KERNEL); - if (IS_ERR(tc->ct)) + if (IS_ERR(tc->ct)) { + err = PTR_ERR(tc->ct); goto err_ct; + } tc->netdevice_nb.notifier_call = mlx5e_tc_netdev_event; err = register_netdevice_notifier_dev_net(priv->netdev,
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic flows") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wang Hai <wanghai38@huawei.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)