| Message ID | 20201027105117.23052-2-tobias@waldekranz.com |
|---|---|
| State | RFC |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: dsa: link aggregation support | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Guessed tree name to be net-next |
| jkicinski/subject_prefix | warning | Target tree name not specified in the subject |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | fail | Errors and warnings before: 4 this patch: 4 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | fail | Link |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
On Tue, 27 Oct 2020 11:51:14 +0100 Tobias Waldekranz <tobias@waldekranz.com> wrote: > The policy is to use ethertyped DSA for all devices that are capable > of doing so, which the Peridot is. What is the benefit here?
On Tue, 27 Oct 2020 15:52:13 +0100 Marek Behun <marek.behun@nic.cz> wrote: > On Tue, 27 Oct 2020 11:51:14 +0100 > Tobias Waldekranz <tobias@waldekranz.com> wrote: > > > The policy is to use ethertyped DSA for all devices that are capable > > of doing so, which the Peridot is. > > What is the benefit here? Also, when you are changing something for 6390, please do the same change for the non-industrial version of Peridot (6190, 6190X), for 6290 and 6191. And since Topaz (6341 and 6141) are basically smaller Peridot's (with 6 ports instead of 11), such a change should also go there. But again, what is the benefit here? Marek
On Tue, 27 Oct 2020 15:54:36 +0100
Marek Behun <marek.behun@nic.cz> wrote:
> But again, what is the benefit here?
OK, you need this for the LAG support, somehow those emails went to
another folder, sorry :)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index bd297ae7cf9e..536ee6cff779 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -5100,7 +5100,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { .atu_move_port_mask = 0x1f, .pvt = true, .multi_chip = true, - .tag_protocol = DSA_TAG_PROTO_DSA, + .tag_protocol = DSA_TAG_PROTO_EDSA, .ptp_support = true, .ops = &mv88e6390_ops, }, @@ -5124,7 +5124,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { .atu_move_port_mask = 0x1f, .pvt = true, .multi_chip = true, - .tag_protocol = DSA_TAG_PROTO_DSA, + .tag_protocol = DSA_TAG_PROTO_EDSA, .ptp_support = true, .ops = &mv88e6390x_ops, },
The policy is to use ethertyped DSA for all devices that are capable of doing so, which the Peridot is. Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)