| Message ID | 20200927080150.8479-1-yangbo.lu@nxp.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | ptp: add stub function for ptp_get_msgtype() | expand |
On 9/27/20 1:01 AM, Yangbo Lu wrote: > Added the missing stub function for ptp_get_msgtype(). > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 036c508ba95e ("ptp: Add generic ptp message type function") > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> Yes, that works. Thanks. Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested > --- > include/linux/ptp_classify.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/ptp_classify.h b/include/linux/ptp_classify.h > index 8437307..c6487b7 100644 > --- a/include/linux/ptp_classify.h > +++ b/include/linux/ptp_classify.h > @@ -134,5 +134,13 @@ static inline struct ptp_header *ptp_parse_header(struct sk_buff *skb, > { > return NULL; > } > +static inline u8 ptp_get_msgtype(const struct ptp_header *hdr, > + unsigned int type) > +{ > + /* The return is meaningless. The stub function would not be > + * executed since no available header from ptp_parse_header. > + */ > + return 0; > +} > #endif > #endif /* _PTP_CLASSIFY_H_ */ >
From: Yangbo Lu <yangbo.lu@nxp.com> Date: Sun, 27 Sep 2020 16:01:50 +0800 > Added the missing stub function for ptp_get_msgtype(). > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 036c508ba95e ("ptp: Add generic ptp message type function") > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> Applied to net-next, thanks.
On Sun Sep 27 2020, Yangbo Lu wrote: > Added the missing stub function for ptp_get_msgtype(). > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 036c508ba95e ("ptp: Add generic ptp message type function") > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> Oh, my bad. Thanks for fixing it. Thanks, Kurt
diff --git a/include/linux/ptp_classify.h b/include/linux/ptp_classify.h index 8437307..c6487b7 100644 --- a/include/linux/ptp_classify.h +++ b/include/linux/ptp_classify.h @@ -134,5 +134,13 @@ static inline struct ptp_header *ptp_parse_header(struct sk_buff *skb, { return NULL; } +static inline u8 ptp_get_msgtype(const struct ptp_header *hdr, + unsigned int type) +{ + /* The return is meaningless. The stub function would not be + * executed since no available header from ptp_parse_header. + */ + return 0; +} #endif #endif /* _PTP_CLASSIFY_H_ */
Added the missing stub function for ptp_get_msgtype(). Reported-by: Randy Dunlap <rdunlap@infradead.org> Fixes: 036c508ba95e ("ptp: Add generic ptp message type function") Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> --- include/linux/ptp_classify.h | 8 ++++++++ 1 file changed, 8 insertions(+)