| Message ID | 20200921120818.31182-1-zhengyongjun3@huawei.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: microchip: Make `lan743x_pm_suspend` function return right value | expand |
From: Zheng Yongjun <zhengyongjun3@huawei.com> Date: Mon, 21 Sep 2020 20:08:18 +0800 > @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev) > /* Host sets PME_En, put D3hot */ > ret = pci_prepare_to_sleep(pdev); > > - return 0; > + return ret; > } Instead please do: return pci_preprare_to_sleep(pdev); And if 'ret' is then completely unused as a result, remove it.
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index de93cc6ebc1a..56a1b5928f9a 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev) /* Host sets PME_En, put D3hot */ ret = pci_prepare_to_sleep(pdev); - return 0; + return ret; } static int lan743x_pm_resume(struct device *dev)
drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend: `ret` is set but not used. In fact, `ret` should be the right value of `lan743x_pm_suspend` function, therefore, fix it. Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- drivers/net/ethernet/microchip/lan743x_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)