| Message ID | 20200918130210.16902-1-wanghai38@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio | expand |
On Fri, 2020-09-18 at 21:02 +0800, Wang Hai wrote: > If the header file containing a function's prototype isn't included > by > the sourcefile containing the associated function, the build system > complains of missing prototypes. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: > no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [- > Wmissing-prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: > no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: > no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: > no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: > no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: > no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing- > prototypes] > > Signed-off-by: Wang Hai <wanghai38@huawei.com> > Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
From: Wang Hai <wanghai38@huawei.com> Date: Fri, 18 Sep 2020 21:02:10 +0800 > If the header file containing a function's prototype isn't included by > the sourcefile containing the associated function, the build system > complains of missing prototypes. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-Wmissing-prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes] > > Signed-off-by: Wang Hai <wanghai38@huawei.com> Applied.
diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index 50b533ff58e6..cd5d5d6e7e5e 100644 --- a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c +++ b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c @@ -26,6 +26,7 @@ #include "cn66xx_regs.h" #include "cn66xx_device.h" #include "cn68xx_regs.h" +#include "cn68xx_device.h" static void lio_cn68xx_set_dpi_regs(struct octeon_device *oct) { diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c b/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c index 4c85ae643b7b..7ccab36143c1 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c @@ -22,6 +22,7 @@ #include "octeon_iq.h" #include "response_manager.h" #include "octeon_device.h" +#include "octeon_mem_ops.h" #define MEMOPS_IDX BAR1_INDEX_DYNAMIC_MAP
If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes. Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes] Signed-off-by: Wang Hai <wanghai38@huawei.com> --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 + drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c | 1 + 2 files changed, 2 insertions(+)