| Message ID | 20200911103509.22907-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | ipv6: remove redundant assignment to variable err | expand |
On 9/11/20 4:35 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable err is being initialized with a value that is never read and > it is being updated later with a new value. The initialization is redundant > and can be removed. Also re-order variable declarations in reverse > Christmas tree ordering. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > net/ipv6/route.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: David Ahern <dsahern@gmail.com>
From: Colin King <colin.king@canonical.com> Date: Fri, 11 Sep 2020 11:35:09 +0100 > From: Colin Ian King <colin.king@canonical.com> > > The variable err is being initialized with a value that is never read and > it is being updated later with a new value. The initialization is redundant > and can be removed. Also re-order variable declarations in reverse > Christmas tree ordering. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied.
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 5e7e25e2523a..e8ee20720fe0 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5284,9 +5284,10 @@ static int ip6_route_multipath_del(struct fib6_config *cfg, { struct fib6_config r_cfg; struct rtnexthop *rtnh; + int last_err = 0; int remaining; int attrlen; - int err = 1, last_err = 0; + int err; remaining = cfg->fc_mp_len; rtnh = (struct rtnexthop *)cfg->fc_mp;