| Message ID | 20200905085058.68312-1-wanghai38@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,v2] net/packet: Remove unused macro BLOCK_PRIV | expand |
On Sat, Sep 5, 2020 at 10:53 AM Wang Hai <wanghai38@huawei.com> wrote: > > BLOCK_PRIV is never used after it was introduced. > So better to remove it. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wang Hai <wanghai38@huawei.com> Acked-by: Willem de Bruijn <willemb@google.com>
On Sat, 5 Sep 2020 11:15:05 +0200 Willem de Bruijn wrote: > On Sat, Sep 5, 2020 at 10:53 AM Wang Hai <wanghai38@huawei.com> wrote: > > > > BLOCK_PRIV is never used after it was introduced. > > So better to remove it. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Wang Hai <wanghai38@huawei.com> > > Acked-by: Willem de Bruijn <willemb@google.com> Applied, thanks!
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index da8254e680f9..c430672c6a67 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -177,7 +177,6 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u, #define BLOCK_LEN(x) ((x)->hdr.bh1.blk_len) #define BLOCK_SNUM(x) ((x)->hdr.bh1.seq_num) #define BLOCK_O2PRIV(x) ((x)->offset_to_priv) -#define BLOCK_PRIV(x) ((void *)((char *)(x) + BLOCK_O2PRIV(x))) struct packet_sock; static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev,
BLOCK_PRIV is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wang Hai <wanghai38@huawei.com> --- v1->v2: Corrected the wrong comment net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-)