| Message ID | 20200818114132.17510-1-linmiaohe@huawei.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: Avoid strcmp current->comm with warncomm when warned >= 5 | expand |
From: Miaohe Lin <linmiaohe@huawei.com> Date: Tue, 18 Aug 2020 07:41:32 -0400 > @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char *name) > { > static int warned; > static char warncomm[TASK_COMM_LEN]; > - if (strcmp(warncomm, current->comm) && warned < 5) { > + if (warned < 5 && strcmp(warncomm, current->comm)) { > strcpy(warncomm, current->comm); > pr_warn("process `%s' is using obsolete %s SO_BSDCOMPAT\n", > warncomm, name); We've been warning about SO_BSDCOMPAT usage for almost 20 years, I think we can remove this code completely now.
diff --git a/net/core/sock.c b/net/core/sock.c index e4f40b175acb..51e13bc42791 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char *name) { static int warned; static char warncomm[TASK_COMM_LEN]; - if (strcmp(warncomm, current->comm) && warned < 5) { + if (warned < 5 && strcmp(warncomm, current->comm)) { strcpy(warncomm, current->comm); pr_warn("process `%s' is using obsolete %s SO_BSDCOMPAT\n", warncomm, name);
We can possibly avoid strcmp warncomm with current->comm by check warned first. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- net/core/sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)