Message ID | 20200611224708.235014-2-saeedm@mellanox.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.a=rsa-sha256 header.s=selector1 header.b=r5GIxJBc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49jfBp086Gz9sRk for <patchwork-incoming-netdev@ozlabs.org>; Fri, 12 Jun 2020 08:47:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbgFKWrp (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Thu, 11 Jun 2020 18:47:45 -0400 Received: from mail-vi1eur05on2064.outbound.protection.outlook.com ([40.107.21.64]:6125 "EHLO EUR05-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726277AbgFKWrn (ORCPT <rfc822;netdev@vger.kernel.org>); Thu, 11 Jun 2020 18:47:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZo8OCCDdUsjFhwgqcffIwA604wc6M+g7JXBJSRK14K0NhxrcerwMoehFSa2BSG3rrFBGUHYHmiajEFNole49S9l/1suDjFim9gmRvh6b9tuzrwcbjM0c8oOMxdY7y2ch1zU31TzIHRo50HU7FsXKb6SSEJJcDAKKEEm+4+K0r4PkDIsmgwR4mERUcjwbLEIki8t5Etdn6GXTCbieQCOUm0LygZzlItLoOogSk2B4d5/tt+hh2zuhvSGkJQex09rq5waZbn+YUPP2jG9CHpz8SNU+1Dvu2bd1X+zKsXZ30RGIVGupUXDmZQM23WJnqLhwAiXU4+ximQ1mtq0sXewBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvxqB6O8MIsVx3V8EKXCHOLkhTBBBvMb85AA9xy+SMQ=; b=TelIuSoPFQgp/A4zk1vTveTWAiKNYf6OI8vcCr6LcQxfxJ311SbDquHrXk94G9LiQrwBuk0Ebrx/ffHk6tfO90jPKw4naLD0ynm0GEwbqiaXe30h2o3f8l74xhmkPlF6mg3TaWo5s0L05z3NfI1Zq5oeen1ogy1OgYhm+s0UJu3kZMtjUGiTXYNjWUd0q5WNo5bV6v/cO8VCa+Gey3L80ufFyab+MonVyHdkROqNmTjh4HaPaW9Xl1YSqMUsLSH1F3fH473yeMcS1v3vUikjaSh0B1dWELax7ADIpmCUZj+557yarExIcnXpHC1hNd+NR6MRO/3pk0JKcG8IiUnt3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvxqB6O8MIsVx3V8EKXCHOLkhTBBBvMb85AA9xy+SMQ=; b=r5GIxJBczxLo/mzGLUOPAzhOUgFTiru2AgMEpVDOLZ7DUQz0ROzsVCW92G+hmrvsczxMqxbAAQEZj6bg9YWguQRm4rq4RwGR79i3ZBMYkMg+YMOlyBC3Hw20h5dp9JtyAuX2pyA9kyYkGTa3aYeJRG7/sCOoGMDwdMKv0mBzc+I= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) by VI1PR05MB4464.eurprd05.prod.outlook.com (2603:10a6:803:44::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.22; Thu, 11 Jun 2020 22:47:39 +0000 Received: from VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c]) by VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::2405:4594:97a:13c%2]) with mapi id 15.20.3088.021; Thu, 11 Jun 2020 22:47:39 +0000 From: Saeed Mahameed <saeedm@mellanox.com> To: "David S. Miller" <davem@davemloft.net>, kuba@kernel.org Cc: netdev@vger.kernel.org, Shay Drory <shayd@mellanox.com>, Moshe Shemesh <moshe@mellanox.com>, Saeed Mahameed <saeedm@mellanox.com> Subject: [net 01/10] net/mlx5: drain health workqueue in case of driver load error Date: Thu, 11 Jun 2020 15:46:59 -0700 Message-Id: <20200611224708.235014-2-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200611224708.235014-1-saeedm@mellanox.com> References: <20200611224708.235014-1-saeedm@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BYAPR06CA0066.namprd06.prod.outlook.com (2603:10b6:a03:14b::43) To VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR06CA0066.namprd06.prod.outlook.com (2603:10b6:a03:14b::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.20 via Frontend Transport; Thu, 11 Jun 2020 22:47:37 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6e7ad67a-6ca0-4243-82fc-08d80e597139 X-MS-TrafficTypeDiagnostic: VI1PR05MB4464: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <VI1PR05MB446472EAACC5BFA14A7A6F70BE800@VI1PR05MB4464.eurprd05.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-Forefront-PRVS: 0431F981D8 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HpBzxIw9CvJq/R5dpPifTUvqh/xfLpkDRwjgl6saBXTG47b/4KgWWfB1VP9mBr0d6zSLsGlxvmLzHIrHMbFgRck4UYVadbyJe06ArdX4kKqJQXUViiiWsI+rKs+mrcrd6FVTdZgC1nz1iPW3YHdcXj9fo7XUjyxf/dMPAulDXn/JuV1ViXA8V53BtC5/ypTCSxxCXXdR+0c8b1DpWUiSA2TR12zlyD+afA3yxSQjTRGarSuYQd/vaBsyGiqrm5KAIBvtsNE0LHCE3xIiiA0ILqN1lC76g7fhUEHXqolQZfhYIhtqefnhuA67xDa/DY8/5PqJnj022+2TRmXigmrgjQ13a6tLs2TreseJWjbHybbBgPUFb8M6tf/zGqOwX2tY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB5102.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(39860400002)(376002)(136003)(346002)(396003)(8936002)(16526019)(186003)(4326008)(316002)(8676002)(107886003)(5660300002)(478600001)(26005)(956004)(2616005)(6666004)(66556008)(86362001)(6512007)(6486002)(66946007)(54906003)(1076003)(6506007)(36756003)(45080400002)(66476007)(83380400001)(2906002)(52116002)(54420400002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: lWl0OSO7Ib1CkWF5K03bdn9LujGf1Qc9kX1mLhewi0omgrbJ1K/Dg4ykPk2SwtmePFT10cT6MGHCGpOtFnUO0NjUV5gEoC3PODZa1GBX52iUoHZYtVHXWWQPtLN7B7k0f6Sz9P4BzTq94gDAbdohBylCg6caSSoDwaHM/UWnxLDDfNcXbGZ3uOk27h+TiAEPKuLEiRjQwXDVCikbMkDXRa7gU4wL9HoINLL0H9ZJEh+r15aais8w1R8G1jMcmOOp3oWQ1J7Qd1vsTokTQT+zwqrSy/5v6MrVPAAkQiWHMz4hci2thuQ8BalmDX37df4HzD8mM5KkFm7/CTtiKbTmWYKLFknfdaYKRVguRMk18efNJdREQ38edW7RsDZ4rOpEylF8LFb0ob8xd8BCRjNRiRfUK3EDEeeu1CcWDkqRJaXGs85GOknH2PCdULfa5BtnrkjG0J7rkN/Czqj8dNsBvRhZB0QoKzDcbQziqO0+lM8= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e7ad67a-6ca0-4243-82fc-08d80e597139 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2020 22:47:39.3464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YYhKx9Mlfe5hWHV57MNWdLWhfm6jTOe5KJsIbo0tykWmS6Lo9Sgkr/PW9NcJy5kz1UpkWJZ9VDz1x/NNGpqVbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4464 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
[net,01/10] net/mlx5: drain health workqueue in case of driver load error
|
expand
|
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index df46b1fce3a70..18d6c3752abe8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c @@ -785,6 +785,11 @@ static int mlx5_pci_init(struct mlx5_core_dev *dev, struct pci_dev *pdev, static void mlx5_pci_close(struct mlx5_core_dev *dev) { + /* health work might still be active, and it needs pci bar in + * order to know the NIC state. Therefore, drain the health WQ + * before removing the pci bars + */ + mlx5_drain_health_wq(dev); iounmap(dev->iseg); pci_clear_master(dev->pdev); release_bar(dev->pdev);