| Message ID | 20200528214324.853699-1-andrew@lunn.ch |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ethtool: cabletest: Make ethnl_act_cable_test_tdr_cfg static | expand |
From: Andrew Lunn <andrew@lunn.ch> Date: Thu, 28 May 2020 23:43:24 +0200 > kbuild test robot is reporting: > net/ethtool/cabletest.c:230:5: warning: no previous prototype for > > Mark the function as static. > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Applied, thanks Andrew. Please put "net-next" or similar next time. Also, a Fixes: tag would have been nice but I won't require it for something like this. Hmmm, I also just noticed how onerous that PHYLINK=y/n requirement is for the ethtool netlink stuff :-/
diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c index 9991688d7d1d..7b7a0456c15c 100644 --- a/net/ethtool/cabletest.c +++ b/net/ethtool/cabletest.c @@ -227,9 +227,9 @@ cable_test_tdr_act_policy[ETHTOOL_A_CABLE_TEST_TDR_MAX + 1] = { }; /* CABLE_TEST_TDR_ACT */ -int ethnl_act_cable_test_tdr_cfg(const struct nlattr *nest, - struct genl_info *info, - struct phy_tdr_config *cfg) +static int ethnl_act_cable_test_tdr_cfg(const struct nlattr *nest, + struct genl_info *info, + struct phy_tdr_config *cfg) { struct nlattr *tb[ETHTOOL_A_CABLE_TEST_TDR_CFG_MAX + 1]; int ret;
kbuild test robot is reporting: net/ethtool/cabletest.c:230:5: warning: no previous prototype for Mark the function as static. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- net/ethtool/cabletest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)