| Message ID | 20200513002327.13637-1-olteanv@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: dsa: tag_sja1105: appease sparse checks for ethertype accessors | expand |
From: Vladimir Oltean <olteanv@gmail.com> Date: Wed, 13 May 2020 03:23:27 +0300 > A comparison between a value from the packet and an integer constant > value needs to be done by converting the value from the packet from > net->host, or the constant from host->net. Not the other way around. > Even though it makes no practical difference, correct that. > > Fixes: 38b5beeae7a4 ("net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously") > Signed-off-by: Vladimir Oltean <olteanv@gmail.com> Applied.
diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c index ad105550b145..9b4a4d719291 100644 --- a/net/dsa/tag_sja1105.c +++ b/net/dsa/tag_sja1105.c @@ -73,10 +73,10 @@ static bool sja1105_can_use_vlan_as_tags(const struct sk_buff *skb) { struct vlan_ethhdr *hdr = vlan_eth_hdr(skb); - if (hdr->h_vlan_proto == ntohs(ETH_P_SJA1105)) + if (hdr->h_vlan_proto == htons(ETH_P_SJA1105)) return true; - if (hdr->h_vlan_proto != ntohs(ETH_P_8021Q)) + if (hdr->h_vlan_proto != htons(ETH_P_8021Q)) return false; return vid_is_dsa_8021q(ntohs(hdr->h_vlan_TCI) & VLAN_VID_MASK);
A comparison between a value from the packet and an integer constant value needs to be done by converting the value from the packet from net->host, or the constant from host->net. Not the other way around. Even though it makes no practical difference, correct that. Fixes: 38b5beeae7a4 ("net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously") Signed-off-by: Vladimir Oltean <olteanv@gmail.com> --- net/dsa/tag_sja1105.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)