diff mbox series

[-next] net/mlxfw: Remove unneeded semicolon

Message ID 20200424090015.90790-1-zhengbin13@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [-next] net/mlxfw: Remove unneeded semicolon | expand

Commit Message

Zheng Bin April 24, 2020, 9 a.m. UTC 
Fixes coccicheck warning:

drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:79:2-3: Unneeded semicolon
drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:162:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.26.0.106.g9fadedd

Comments

Ido Schimmel April 24, 2020, 1:03 p.m. UTC | #1 
On Fri, Apr 24, 2020 at 05:00:15PM +0800, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:79:2-3: Unneeded semicolon
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:162:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

Reviewed-by: Ido Schimmel <idosch@mellanox.com>

Thanks
David Miller April 24, 2020, 11:56 p.m. UTC | #2 
From: Zheng Bin <zhengbin13@huawei.com>
Date: Fri, 24 Apr 2020 17:00:15 +0800

> Fixes coccicheck warning:
> 
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:79:2-3: Unneeded semicolon
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:162:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c
index 046a0cb82ed8..7a04c626a2aa 100644
--- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c
+++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c
@@ -76,7 +76,7 @@  static int mlxfw_fsm_state_err(struct mlxfw_dev *mlxfw_dev,
 	case MLXFW_FSM_STATE_ERR_MAX:
 		MLXFW_ERR_MSG(mlxfw_dev, extack, "unknown error", err);
 		break;
-	};
+	}

 	return mlxfw_fsm_state_errno[fsm_state_err];
 };
@@ -159,7 +159,7 @@  mlxfw_fsm_reactivate_err(struct mlxfw_dev *mlxfw_dev,
 	case MLXFW_FSM_REACTIVATE_STATUS_MAX:
 		MLXFW_REACT_ERR("unexpected error", err);
 		break;
-	};
+	}
 	return -EREMOTEIO;
 };