| Message ID | 20200415041112.32679-1-ben@b1c1l1.com |
|---|---|
| State | Accepted |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] tc: fq_codel: fix class stat deficit is signed int | expand |
On Tue, 14 Apr 2020 21:11:12 -0700 Benjamin Lee <ben@b1c1l1.com> wrote: > The fq_codel class stat deficit is a signed int. This is a regression > from when JSON output was added. > > Fixes: 997f2dc19378 ("tc: Add JSON output of fq_codel stats") > Signed-off-by: Benjamin Lee <ben@b1c1l1.com> > --- Applied, thanks
diff --git a/tc/q_fq_codel.c b/tc/q_fq_codel.c index efed4d28..1c6cf1e0 100644 --- a/tc/q_fq_codel.c +++ b/tc/q_fq_codel.c @@ -264,7 +264,7 @@ static int fq_codel_print_xstats(struct qdisc_util *qu, FILE *f, st->qdisc_stats.old_flows_len); } if (st->type == TCA_FQ_CODEL_XSTATS_CLASS) { - print_uint(PRINT_ANY, "deficit", " deficit %u", + print_int(PRINT_ANY, "deficit", " deficit %d", st->class_stats.deficit); print_uint(PRINT_ANY, "count", " count %u", st->class_stats.count);
The fq_codel class stat deficit is a signed int. This is a regression from when JSON output was added. Fixes: 997f2dc19378 ("tc: Add JSON output of fq_codel stats") Signed-off-by: Benjamin Lee <ben@b1c1l1.com> --- tc/q_fq_codel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)