| Message ID | 20200213135100.2963-3-per.forlin@axis.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: dsa: Make sure there is headroom for tag | expand |
Hi, On 13.02.20 14:51, Per@axis.com wrote: > From: Per Forlin <per.forlin@axis.com> > > Passing tag size to skb_cow_head will make sure > there is enough headroom for the tag data. > This change does not introduce any overhead in case there > is already available headroom for tag. > > Signed-off-by: Per Forlin <perfn@axis.com> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! Are you using this driver? > --- > net/dsa/tag_ar9331.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c > index 466ffa92a474..55b00694cdba 100644 > --- a/net/dsa/tag_ar9331.c > +++ b/net/dsa/tag_ar9331.c > @@ -31,7 +31,7 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb, > __le16 *phdr; > u16 hdr; > > - if (skb_cow_head(skb, 0) < 0) > + if (skb_cow_head(skb, AR9331_HDR_LEN) < 0) > return NULL; > > phdr = skb_push(skb, AR9331_HDR_LEN); > Kind regards, Oleksij Rempel
You need to fix your email setup if you want to post patches here. You are providing multiple email addresses in your From: field and almost every major email provider (including gmail) rejects emails with that. So nobody is seeing your postings until you fix this. Thank you.
> > > > Signed-off-by: Per Forlin <perfn@axis.com> > Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> > Thank you! > Are you using this driver? Hi, I'm not using this particular driver. I'm using the tag_qca driver and this driver had the same typo. Br Per
diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c index 466ffa92a474..55b00694cdba 100644 --- a/net/dsa/tag_ar9331.c +++ b/net/dsa/tag_ar9331.c @@ -31,7 +31,7 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb, __le16 *phdr; u16 hdr; - if (skb_cow_head(skb, 0) < 0) + if (skb_cow_head(skb, AR9331_HDR_LEN) < 0) return NULL; phdr = skb_push(skb, AR9331_HDR_LEN);