| Message ID | 20200131050326.n3axoo7axxvzcrv3@kili.mountain |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] qed: Fix a error code in qed_hw_init() | expand |
On Fri, 31 Jan 2020 08:03:26 +0300, Dan Carpenter wrote: > If the qed_fw_overlay_mem_alloc() then we should return -ENOMEM instead > of success. > > Fixes: 30d5f85895fa ("qed: FW 8.42.2.0 Add fw overlay feature") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied, thanks Dan!
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c index 7912911337d4..03bdd2e26329 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c @@ -3114,6 +3114,7 @@ int qed_hw_init(struct qed_dev *cdev, struct qed_hw_init_params *p_params) if (!p_hwfn->fw_overlay_mem) { DP_NOTICE(p_hwfn, "Failed to allocate fw overlay memory\n"); + rc = -ENOMEM; goto load_err; }
If the qed_fw_overlay_mem_alloc() then we should return -ENOMEM instead of success. Fixes: 30d5f85895fa ("qed: FW 8.42.2.0 Add fw overlay feature") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 1 + 1 file changed, 1 insertion(+)