From patchwork Wed Jan 22 11:35:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gautam Ramakrishnan X-Patchwork-Id: 1227195 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Tcdashgp; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 482jyz3dVYz9sP6 for ; Wed, 22 Jan 2020 22:36:11 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729186AbgAVLgK (ORCPT ); Wed, 22 Jan 2020 06:36:10 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:35565 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbgAVLgK (ORCPT ); Wed, 22 Jan 2020 06:36:10 -0500 Received: by mail-pf1-f196.google.com with SMTP id i23so3259891pfo.2 for ; Wed, 22 Jan 2020 03:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lLPfkaHUdJk91hEn7ISh5HhzYqtAwjmDshBoNiXJGwM=; b=Tcdashgpi4sxLpbc07DW2t5OskG1oCjEwAXNEoHAUKaT2AOb7j3TTonT5ubptlSffM nZHSCILCmLziyIaCr0gKO5zEfVNKz/REs5XiMOIG/lU37PAPMQGbHxLn2Bk/QU4qt4K/ Ce7YOKw+b6hDGql5yaS/cLZ09o5u7b3h3CAD5vLVKnID8halGbbprKFHEh4s+IDBuAla qXOcAWIvwbZplhYjFuxb4mVrkCD3cE4TjszxGZofCpz+P35o0wvDzjcyaLmXYDXnuht7 g4bnFw6YHPr82fXYii4OjUhemObM3KcHx2pTpFwz1Gpo6W9mjtxnTKuOTBlH0V4tbu5O LCmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lLPfkaHUdJk91hEn7ISh5HhzYqtAwjmDshBoNiXJGwM=; b=CF4SXSCvk8WMpZOagF3Yz+rqxQPmNOlv+A+wXtBKYTJsedZce5AoBsCVJLXpINtbhY fZPIG4b+7PjgM9uyCuf/cJLBl89IVWkmZiXX7odPushiLVhby9t6xWfkkSWA1oluqUKi zO8KBPiaapURKML1ck/nSlCuy7sP054bPnsuYf525ZxhqRFOyRTiRdNxRF7KsDgAl3tb H8nXo6uGWI29FjwqcuC6/zQjSGoUh2l86zC6Yjv25ZDXu65SnxtpBwtoqnhy4dWrlRiF JvSN31rpEUSoAs82SlnfxVgn+TIOSxi6EEzjmz5KcCg9b2m47cPuH4fPNxxQu98uEYcV DRvw== X-Gm-Message-State: APjAAAV1nIQZTcGmMJmIXq+OT9s5bTVXCb/f86tuI/33kWtn00slE1uS soCDw+LnvKiZ0t2RBqayVbViETqmche7L0ER X-Google-Smtp-Source: APXvYqwX2QGOUiJ/5No35WRqbwTOlVJn7DgUAh3uqG0xvbjYPzdtLGQJailOT0RcssKK8L1OwqfiQg== X-Received: by 2002:a63:5fca:: with SMTP id t193mr10728874pgb.28.1579692969091; Wed, 22 Jan 2020 03:36:09 -0800 (PST) Received: from localhost.localdomain ([223.186.203.82]) by smtp.gmail.com with ESMTPSA id c6sm2145962pgk.78.2020.01.22.03.36.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2020 03:36:08 -0800 (PST) From: gautamramk@gmail.com To: netdev@vger.kernel.org Cc: "Mohit P. Tahiliani" , Jamal Hadi Salim , "David S . Miller" , Dave Taht , =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Jakub Kicinski , Stephen Hemminger , Leslie Monis , Gautam Ramakrishnan Subject: [PATCH net-next v6 04/10] pie: use u8 instead of bool in pie_vars Date: Wed, 22 Jan 2020 17:05:27 +0530 Message-Id: <20200122113533.28128-5-gautamramk@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200122113533.28128-1-gautamramk@gmail.com> References: <20200122113533.28128-1-gautamramk@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" Linux best practice recommends using u8 for true/false values in structures. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Leslie Monis Signed-off-by: Gautam Ramakrishnan --- include/net/pie.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/pie.h b/include/net/pie.h index 397c7abf0879..f9c6a44bdb0c 100644 --- a/include/net/pie.h +++ b/include/net/pie.h @@ -21,8 +21,8 @@ struct pie_params { u32 limit; /* number of packets that can be enqueued */ u32 alpha; /* alpha and beta are between 0 and 32 */ u32 beta; /* and are used for shift relative to 1 */ - bool ecn; /* true if ecn is enabled */ - bool bytemode; /* to scale drop early prob based on pkt size */ + u8 ecn; /* true if ecn is enabled */ + u8 bytemode; /* to scale drop early prob based on pkt size */ u8 dq_rate_estimator; /* to calculate delay using Little's law */ };