From patchwork Tue Jan 21 14:12:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gautam Ramakrishnan X-Patchwork-Id: 1226592 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Y9ld0Tgo; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4829W65wXTz9sPJ for ; Wed, 22 Jan 2020 01:13:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729276AbgAUONh (ORCPT ); Tue, 21 Jan 2020 09:13:37 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:41480 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728904AbgAUONh (ORCPT ); Tue, 21 Jan 2020 09:13:37 -0500 Received: by mail-pl1-f194.google.com with SMTP id t14so1389247plr.8 for ; Tue, 21 Jan 2020 06:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fLMSzwn105nQG1k0Bcg5PrK+NSb62h11DDA8BpA28gE=; b=Y9ld0TgoGtzFYQ4NGnfF+GIRzSzEpoO4uEPZjupsz0woSF8ICj4k9RTSqXkVTr6n7+ Y8VEyNv+5yqfeN1IrNBVzIx3+qgAJVYD3BhLUPfiHVw10/2Hp7Oed188DGV/HdXNLiLz o9Mk2mNmbfqO+p8cPT3fTERVzPuUaHAnY3u3oXCe2z2jspJEyK6+AwDEQacSxcGCI8al l9nxrCNBkONC0du54+TDFwHjY79WiP85NlQD/vdBbvvmWrsesWI2+hBpLepzVQtw9bns rDJiqGAwxY8lsCxrIqkttzkkokPDEnVul3yNucPGrfr+RpXV8ilOH9bWKthkLt4CciVn R/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fLMSzwn105nQG1k0Bcg5PrK+NSb62h11DDA8BpA28gE=; b=OCOAgOZDDJ2hwjdMQUlXpkp8F8URDDrELFFvoAMNzyh3opvKgUa9JaCLQmqBO1hKAD li/0rvPGZNGC84KXNzm/MZ8+c1r0784X2TB3zGlwheEQWEKfFTuL5vDOnr/CsePuBry8 njeXXi/PcFnNR32mRbT4O48xnDVgFsBBY5r3JGGp7eb/UiasyTJW+rG1NoXWhVMW91Cr IlBPAOWXyWhOCyiuI+35f8KlZ9lEpwQvelIgk/cy3/Mi/lAl10hl9sdqhlWKaqKrCe/s IOML2ALVzTsuLFz82D3X6rtFGlwZyMjy4o/NrqF5uLEYIzGLSBSgAeEKP7GCp+xWmPTu 21Ig== X-Gm-Message-State: APjAAAUfJU5ZkCQP1HwyaEWBHqg29ewaHX9i6YgVeQ8R1bM7NL06ka1T LXi5J8U0/8SQW0bhkjrEX0LFIEMy+u9rRw== X-Google-Smtp-Source: APXvYqyWPVK66MS6g6AxyIcwC+MDtKFXD6IoJ1TdadBT+h2EnHvEyB42+S97MQrS95BiAn8iah4FRQ== X-Received: by 2002:a17:90a:8a0c:: with SMTP id w12mr5557925pjn.61.1579616016622; Tue, 21 Jan 2020 06:13:36 -0800 (PST) Received: from localhost.localdomain ([223.186.212.224]) by smtp.gmail.com with ESMTPSA id y203sm44836443pfb.65.2020.01.21.06.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 06:13:36 -0800 (PST) From: gautamramk@gmail.com To: netdev@vger.kernel.org Cc: "Mohit P. Tahiliani" , Jamal Hadi Salim , "David S . Miller" , Dave Taht , =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Jakub Kicinski , Stephen Hemminger , Leslie Monis , Gautam Ramakrishnan Subject: [PATCH net-next v4 07/10] net: sched: pie: fix commenting Date: Tue, 21 Jan 2020 19:42:46 +0530 Message-Id: <20200121141250.26989-8-gautamramk@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200121141250.26989-1-gautamramk@gmail.com> References: <20200121141250.26989-1-gautamramk@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" Fix punctuation and logical mistakes in the comments. The logical mistake was that "dequeue_rate" is no longer the default way to calculate queuing delay and is not needed. The default way to calculate queue delay was changed in commit cec2975f2b70 ("net: sched: pie: enable timestamp based delay calculation"). Signed-off-by: Mohit P. Tahiliani Signed-off-by: Leslie Monis Signed-off-by: Gautam Ramakrishnan --- net/sched/sch_pie.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 7197bcaa14ba..c0a4df01c0a0 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -248,10 +248,10 @@ static void pie_process_dequeue(struct Qdisc *sch, struct sk_buff *skb) q->vars.dq_count = 0; } - /* Calculate the average drain rate from this value. If queue length - * has receded to a small value viz., <= QUEUE_THRESHOLD bytes,reset + /* Calculate the average drain rate from this value. If queue length + * has receded to a small value viz., <= QUEUE_THRESHOLD bytes, reset * the dq_count to -1 as we don't have enough packets to calculate the - * drain rate anymore The following if block is entered only when we + * drain rate anymore. The following if block is entered only when we * have a substantial queue built up (QUEUE_THRESHOLD bytes or more) * and we calculate the drain rate for the threshold here. dq_count is * in bytes, time difference in psched_time, hence rate is in @@ -329,8 +329,8 @@ static void calculate_probability(struct Qdisc *sch) qdelay_old = q->vars.qdelay_old; } - /* If qdelay is zero and qlen is not, it means qlen is very small, less - * than dequeue_rate, so we do not update probabilty in this round + /* If qdelay is zero and qlen is not, it means qlen is very small, + * so we do not update probabilty in this round. */ if (qdelay == 0 && qlen != 0) update_prob = false;