| Message ID | 20191224115812.166927-1-maowenan@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init | expand |
Hi, On Tue, Dec 24, 2019 at 07:58:12PM +0800, Mao Wenan wrote: > There is no need to set variable 'mbus' static > since new value always be assigned before use it. > > Signed-off-by: Mao Wenan <maowenan@huawei.com> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! > --- > v2: change subject and description. > drivers/net/dsa/qca/ar9331.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c > index 0d1a7cd85fe8..da3bece75e21 100644 > --- a/drivers/net/dsa/qca/ar9331.c > +++ b/drivers/net/dsa/qca/ar9331.c > @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum) > static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv) > { > struct device *dev = priv->dev; > - static struct mii_bus *mbus; > + struct mii_bus *mbus; > struct device_node *np, *mnp; > int ret; > > -- > 2.20.1 > >
On Tue, Dec 24, 2019 at 07:58:12PM +0800, Mao Wenan wrote: > There is no need to set variable 'mbus' static > since new value always be assigned before use it. > > Signed-off-by: Mao Wenan <maowenan@huawei.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Mao Wenan <maowenan@huawei.com> Date: Tue, 24 Dec 2019 19:58:12 +0800 > There is no need to set variable 'mbus' static > since new value always be assigned before use it. > > Signed-off-by: Mao Wenan <maowenan@huawei.com> Applied, thank you.
diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index 0d1a7cd85fe8..da3bece75e21 100644 --- a/drivers/net/dsa/qca/ar9331.c +++ b/drivers/net/dsa/qca/ar9331.c @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum) static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv) { struct device *dev = priv->dev; - static struct mii_bus *mbus; + struct mii_bus *mbus; struct device_node *np, *mnp; int ret;
There is no need to set variable 'mbus' static since new value always be assigned before use it. Signed-off-by: Mao Wenan <maowenan@huawei.com> --- v2: change subject and description. drivers/net/dsa/qca/ar9331.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)