| Message ID | 20191224024059.184847-1-maowenan@huawei.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init | expand |
Hi Mao, the commit title should be something of the form net: dsa: qca: ar9331: drop pointless static qualifier or net: dsa: ar9331: drop pointless static qualifier If it begins only with net: dsa: then it makes people think you are changing stuff in main dsa code. Marek On Tue, 24 Dec 2019 10:40:59 +0800 Mao Wenan <maowenan@huawei.com> wrote: > There is no need to have the 'T *v' variable static > since new value always be assigned before use it. > > Signed-off-by: Mao Wenan <maowenan@huawei.com> > --- > drivers/net/dsa/qca/ar9331.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c > index 0d1a7cd85fe8..da3bece75e21 100644 > --- a/drivers/net/dsa/qca/ar9331.c > +++ b/drivers/net/dsa/qca/ar9331.c > @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum) > static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv) > { > struct device *dev = priv->dev; > - static struct mii_bus *mbus; > + struct mii_bus *mbus; > struct device_node *np, *mnp; > int ret; >
On Tue, Dec 24, 2019 at 10:40:59AM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
What does 'T *v' mean?
The patch itself looks O.K, but the description should be better, and
the subject line.
Andrew
diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index 0d1a7cd85fe8..da3bece75e21 100644 --- a/drivers/net/dsa/qca/ar9331.c +++ b/drivers/net/dsa/qca/ar9331.c @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum) static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv) { struct device *dev = priv->dev; - static struct mii_bus *mbus; + struct mii_bus *mbus; struct device_node *np, *mnp; int ret;
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/net/dsa/qca/ar9331.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)