diff mbox series

ARM: dts: BCM5301X: Fix MDIO node address/size cells

Message ID 20191206000421.12541-1-f.fainelli@gmail.com
State Not Applicable
Delegated to: David Miller
Headers show
Series ARM: dts: BCM5301X: Fix MDIO node address/size cells | expand

Commit Message

Florian Fainelli Dec. 6, 2019, 12:04 a.m. UTC
The MDIO node on BCM5301X had an reversed #address-cells and
 #size-cells properties, correct those, silencing checker warnings:

.../linux/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: mdio@18003000: #address-cells:0:0: 1 was expected

Reported-by: Simon Horman <simon.horman@netronome.com>
Fixes: 23f1eca6d59b ("ARM: dts: BCM5301X: Specify MDIO bus in the DT")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Dec. 6, 2019, 9:31 a.m. UTC | #1
On Thu, Dec 05, 2019 at 04:04:21PM -0800, Florian Fainelli wrote:
> The MDIO node on BCM5301X had an reversed #address-cells and
>  #size-cells properties, correct those, silencing checker warnings:
> 
> .../linux/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: mdio@18003000: #address-cells:0:0: 1 was expected
> 
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Fixes: 23f1eca6d59b ("ARM: dts: BCM5301X: Specify MDIO bus in the DT")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks, make dtbs_check seems a lot happier now.

Reviewed-by: Simon Horman <simon.horman@netronome.com>

FWIIW, I think a similar change might also be in order for bcm-cygnus.dtsi.

> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 372dc1eb88a0..2d9b4dd05830 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -353,8 +353,8 @@
>  	mdio: mdio@18003000 {
>  		compatible = "brcm,iproc-mdio";
>  		reg = <0x18003000 0x8>;
> -		#size-cells = <1>;
> -		#address-cells = <0>;
> +		#size-cells = <0>;
> +		#address-cells = <1>;
>  	};
>  
>  	mdio-bus-mux@18003000 {
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 372dc1eb88a0..2d9b4dd05830 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -353,8 +353,8 @@ 
 	mdio: mdio@18003000 {
 		compatible = "brcm,iproc-mdio";
 		reg = <0x18003000 0x8>;
-		#size-cells = <1>;
-		#address-cells = <0>;
+		#size-cells = <0>;
+		#address-cells = <1>;
 	};
 
 	mdio-bus-mux@18003000 {