| Message ID | 20191204213203.163073-1-brianvv@google.com |
|---|---|
| State | Accepted |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2,v2] tc: fix warning in tc/q_pie.c | expand |
On Wed, 4 Dec 2019 13:32:03 -0800 Brian Vazquez <brianvv@google.com> wrote: > Warning was: > q_pie.c:202:22: error: implicit conversion from 'unsigned long' to > 'double' > > Fixes: 492ec9558b30 ("tc: pie: change maximum integer value of tc_pie_xstats->prob") > Cc: Leslie Monis <lesliemonis@gmail.com> > Signed-off-by: Brian Vazquez <brianvv@google.com> > --- Applied
diff --git a/tc/q_pie.c b/tc/q_pie.c index 935548a2..fda98a71 100644 --- a/tc/q_pie.c +++ b/tc/q_pie.c @@ -217,7 +217,7 @@ static int pie_print_xstats(struct qdisc_util *qu, FILE *f, st = RTA_DATA(xstats); /*prob is returned as a fracion of maximum integer value */ fprintf(f, "prob %f delay %uus", - (double)st->prob / UINT64_MAX, st->delay); + (double)st->prob / (double)UINT64_MAX, st->delay); if (st->dq_rate_estimating) fprintf(f, " avg_dq_rate %u\n", st->avg_dq_rate);
Warning was: q_pie.c:202:22: error: implicit conversion from 'unsigned long' to 'double' Fixes: 492ec9558b30 ("tc: pie: change maximum integer value of tc_pie_xstats->prob") Cc: Leslie Monis <lesliemonis@gmail.com> Signed-off-by: Brian Vazquez <brianvv@google.com> --- v2: rebase to current version. tc/q_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)