| Message ID | 20191113183158.rogxsza632ppeen3@kili.mountain |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: atlantic: Signedness bug in aq_vec_isr_legacy() | expand |
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Wed, 13 Nov 2019 21:31:58 +0300 > irqreturn_t type is an enum and in this context it's unsigned, so "err" > can't be irqreturn_t or it breaks the error handling. In fact the "err" > variable is only used to store integers (never irqreturn_t) so it should > be declared as int. > > I removed the initialization because it's not required. Using a bogus > initializer turns off GCC's uninitialized variable warnings. Secondly, > there is a GCC warning about unused assignments and we would like to > enable that feature eventually so we have been trying to remove these > unnecessary initializers. > > Fixes: 7b0c342f1f67 ("net: atlantic: code style cleanup") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_vec.c b/drivers/net/ethernet/aquantia/atlantic/aq_vec.c index 6e19e27b6200..f40a427970dc 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_vec.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_vec.c @@ -307,8 +307,8 @@ irqreturn_t aq_vec_isr(int irq, void *private) irqreturn_t aq_vec_isr_legacy(int irq, void *private) { struct aq_vec_s *self = private; - irqreturn_t err = 0; u64 irq_mask = 0U; + int err; if (!self) return IRQ_NONE;
irqreturn_t type is an enum and in this context it's unsigned, so "err" can't be irqreturn_t or it breaks the error handling. In fact the "err" variable is only used to store integers (never irqreturn_t) so it should be declared as int. I removed the initialization because it's not required. Using a bogus initializer turns off GCC's uninitialized variable warnings. Secondly, there is a GCC warning about unused assignments and we would like to enable that feature eventually so we have been trying to remove these unnecessary initializers. Fixes: 7b0c342f1f67 ("net: atlantic: code style cleanup") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/aquantia/atlantic/aq_vec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)