diff mbox series

[net-next] selftests/net: fix warnings in TFO key rotation selftest

Message ID 20190616171501.142551-1-willemdebruijn.kernel@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] selftests/net: fix warnings in TFO key rotation selftest | expand

Commit Message

Willem de Bruijn June 16, 2019, 5:15 p.m. UTC 
From: Willem de Bruijn <willemb@google.com>

One warning each on signedness, unused variable and return type.

Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")
Signed-off-by: Willem de Bruijn <willemb@google.com>
---
 tools/testing/selftests/net/tcp_fastopen_backup_key.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

David Miller June 16, 2019, 9:27 p.m. UTC | #1 
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Sun, 16 Jun 2019 13:15:01 -0400

> From: Willem de Bruijn <willemb@google.com>
> 
> One warning each on signedness, unused variable and return type.
> 
> Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")
> Signed-off-by: Willem de Bruijn <willemb@google.com>

Applied.
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/tcp_fastopen_backup_key.c b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
index 58bb77d9e7e1..9c55ec44fc43 100644
--- a/tools/testing/selftests/net/tcp_fastopen_backup_key.c
+++ b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
@@ -51,7 +51,7 @@  static const int PORT = 8891;
 static void get_keys(int fd, uint32_t *keys)
 {
 	char buf[128];
-	int len = KEY_LENGTH * 2;
+	socklen_t len = KEY_LENGTH * 2;
 
 	if (do_sockopt) {
 		if (getsockopt(fd, SOL_TCP, TCP_FASTOPEN_KEY, keys, &len))
@@ -210,14 +210,13 @@  static bool is_listen_fd(int fd)
 	return false;
 }
 
-static int rotate_key(int fd)
+static void rotate_key(int fd)
 {
 	static int iter;
 	static uint32_t new_key[4];
 	uint32_t keys[8];
 	uint32_t tmp_key[4];
 	int i;
-	int len = KEY_LENGTH * 2;
 
 	if (iter < N_LISTEN) {
 		/* first set new key as backups */