| Message ID | 20190606094727.23868-1-anders.roxell@linaro.org |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | fix warnings for same module names | expand |
On Thu, Jun 06, 2019 at 11:47:26AM +0200, Anders Roxell wrote: > When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as > loadable modules, we see the following warning: > > warning: same module names found: > drivers/net/phy/asix.ko > drivers/net/usb/asix.ko > > Rework so media coda matches the config fragment. Leaving No media coda here. > CONFIG_USB_NET_AX8817X as is since thats a well known module. Again, place base on net-next and submit to just netdev. Please rename the PHY driver asix88796. Andrew
Hi Andew, Anders, sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY driver that I just forgot to resend. It'll clash with your patch, Anders - are you happy to drop the CONFIG_ASIX_PHY from your series? Cheers, Michael On 7/06/19 12:58 AM, Andrew Lunn wrote: > On Thu, Jun 06, 2019 at 11:47:26AM +0200, Anders Roxell wrote: >> When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as >> loadable modules, we see the following warning: >> >> warning: same module names found: >> drivers/net/phy/asix.ko >> drivers/net/usb/asix.ko >> >> Rework so media coda matches the config fragment. Leaving > No media coda here. > >> CONFIG_USB_NET_AX8817X as is since thats a well known module. > Again, place base on net-next and submit to just netdev. > > Please rename the PHY driver asix88796. > > Andrew
On Fri, Jun 07, 2019 at 12:34:47PM +1200, Michael Schmitz wrote: > Hi Andew, Anders, > > sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY > driver that I just forgot to resend. > > It'll clash with your patch, Anders - are you happy to drop the > CONFIG_ASIX_PHY from your series? Hi Michael Please send your patch. Anders needs to split up his patchset anyway, so dropping one is not a problem. Andrew
Hi Andrew, Am 07.06.2019 um 13:59 schrieb Andrew Lunn: > On Fri, Jun 07, 2019 at 12:34:47PM +1200, Michael Schmitz wrote: >> Hi Andew, Anders, >> >> sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY >> driver that I just forgot to resend. >> >> It'll clash with your patch, Anders - are you happy to drop the >> CONFIG_ASIX_PHY from your series? > > Hi Michael > > Please send your patch. Anders needs to split up his patchset anyway, > so dropping one is not a problem. Done, thanks for your feedback. Cheers, Michael > > Andrew >
diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile index 947c974bc69e..bab179b75a2a 100644 --- a/drivers/net/phy/Makefile +++ b/drivers/net/phy/Makefile @@ -52,7 +52,8 @@ ifdef CONFIG_HWMON aquantia-objs += aquantia_hwmon.o endif obj-$(CONFIG_AQUANTIA_PHY) += aquantia.o -obj-$(CONFIG_ASIX_PHY) += asix.o +obj-$(CONFIG_ASIX_PHY) += asix-phy.o +asix-phy-objs := asix.o obj-$(CONFIG_AT803X_PHY) += at803x.o obj-$(CONFIG_BCM63XX_PHY) += bcm63xx.o obj-$(CONFIG_BCM7XXX_PHY) += bcm7xxx.o
When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as loadable modules, we see the following warning: warning: same module names found: drivers/net/phy/asix.ko drivers/net/usb/asix.ko Rework so media coda matches the config fragment. Leaving CONFIG_USB_NET_AX8817X as is since thats a well known module. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/net/phy/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)