diff mbox series

[net-next] net: dummy: use generic helper to report timestamping info

Message ID 20190412110615.9266-1-jwi@linux.ibm.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] net: dummy: use generic helper to report timestamping info | expand

Commit Message

Julian Wiedmann April 12, 2019, 11:06 a.m. UTC 
For reporting the common set of SW timestamping capabilities, use
ethtool_op_get_ts_info() instead of re-implementing it.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
 drivers/net/dummy.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

Comments

David Miller April 12, 2019, 11:27 p.m. UTC | #1 
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Fri, 12 Apr 2019 13:06:13 +0200

> For reporting the common set of SW timestamping capabilities, use
> ethtool_op_get_ts_info() instead of re-implementing it.
> 
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c
index 0d15a12a4560..3568129fb7da 100644
--- a/drivers/net/dummy.c
+++ b/drivers/net/dummy.c
@@ -32,6 +32,7 @@ 
 #include <linux/kernel.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
+#include <linux/ethtool.h>
 #include <linux/init.h>
 #include <linux/moduleparam.h>
 #include <linux/rtnetlink.h>
@@ -131,21 +132,9 @@  static void dummy_get_drvinfo(struct net_device *dev,
 	strlcpy(info->version, DRV_VERSION, sizeof(info->version));
 }
 
-static int dummy_get_ts_info(struct net_device *dev,
-			      struct ethtool_ts_info *ts_info)
-{
-	ts_info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
-				   SOF_TIMESTAMPING_RX_SOFTWARE |
-				   SOF_TIMESTAMPING_SOFTWARE;
-
-	ts_info->phc_index = -1;
-
-	return 0;
-};
-
 static const struct ethtool_ops dummy_ethtool_ops = {
 	.get_drvinfo            = dummy_get_drvinfo,
-	.get_ts_info		= dummy_get_ts_info,
+	.get_ts_info		= ethtool_op_get_ts_info,
 };
 
 static void dummy_setup(struct net_device *dev)