From patchwork Thu Apr 11 22:53:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislav Fomichev X-Patchwork-Id: 1084353 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="alFmC1ik"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44gGXK3Fr4z9s55 for ; Fri, 12 Apr 2019 08:53:21 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbfDKWxT (ORCPT ); Thu, 11 Apr 2019 18:53:19 -0400 Received: from mail-yb1-f202.google.com ([209.85.219.202]:35024 "EHLO mail-yb1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbfDKWxT (ORCPT ); Thu, 11 Apr 2019 18:53:19 -0400 Received: by mail-yb1-f202.google.com with SMTP id k188so5513413yba.2 for ; Thu, 11 Apr 2019 15:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=89cLoKzdA+Opv4mmJFcFHfwcAuc2qXLh/tLsHRqWMno=; b=alFmC1ikaeyTbzHN1bqKX8ll5Vfgn7bGiPoN0n+9dMxJ0fvaOrWs/+otpdQInh8tao UQ3PXsYSvdq2fJ9iOuW/l8+kcyk90Zlpew9INQsglIpTw6di9OgosUdLA6lTtBWi6V0q KRIvdVafd9z0BjIIzwIg+G8igtevHasvB4cWyi4zodPTzkYALX270FJJh2rlxfPvamut FQKSLPiz0YV5iouaFapgDzU+mZvjb3bRiOaCfQQhmnElo3B7Cd2m6hPWFdTzGPntpnwz 6Gu3TqLbGqhtHVuNjeHUbJNL4tfY3H2jsEPrXhX1EnF4LnC6Jg7fHQCzFviQX4vcaEav F+NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=89cLoKzdA+Opv4mmJFcFHfwcAuc2qXLh/tLsHRqWMno=; b=H0BOiT2yblYd63+xnJsh8Pi6xu27dGYTBk7woBytREVNxJqyDIxmZIvIMA/YSbnjgq cRJ58JD1z/aIb2msjCsPjOBVAR5wtorJULSBRw/d4IBj1Da26+6MmbGP4/2wjPmTeyN4 IWP56lNP42mAnMqq13uoXo0E5UwWws0I2cFaxYQxL8rRRhV9WhvYL0YnCOes9rCLa3vu awxNMDIuzKcJ0YHY4bMNBkBQZq7lMRXhCRzOTyloSmTFSWmJYK6ctbybSBnHA+1CFrml cTkn6HPXOCodLWc0/hHb+yLgqENGrXWgI3pIOctbR2Hp+3EdoYUMg3K4DmF/j+uXt084 fgYQ== X-Gm-Message-State: APjAAAXZI9MXf6+KnduGNFtmtjpZUf1xxzO7xOG1Sk51n8p6gHrizeMA 8T+dKnBYGA8KofC1DvpwQHeWqrk= X-Google-Smtp-Source: APXvYqyIB2kmK4axauSXt9gS2jmbeAPtMNRuTb7tiIfWudzFMxc6sFoqBkPAgxoMr+hrJL8Gj742AHw= X-Received: by 2002:a25:dc43:: with SMTP id y64mr3653100ybe.11.1555023198817; Thu, 11 Apr 2019 15:53:18 -0700 (PDT) Date: Thu, 11 Apr 2019 15:53:16 -0700 Message-Id: <20190411225316.125106-1-sdf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog Subject: [PATCH bpf-next] selftests/bpf: bring back (void *) cast to set_ipv4_csum in test_tc_tunnel From: Stanislav Fomichev To: netdev@vger.kernel.org, bpf@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev , Alan Maguire , Willem de Bruijn Sender: bpf-owner@vger.kernel.org Precedence: bulk List-Id: netdev.vger.kernel.org It was removed in commit 166b5a7f2ca3 ("selftests_bpf: extend test_tc_tunnel for UDP encap") without any explanation. Otherwise I see: progs/test_tc_tunnel.c:160:17: warning: taking address of packed member 'ip' of class or structure 'v4hdr' may result in an unaligned pointer value [-Waddress-of-packed-member] set_ipv4_csum(&h_outer.ip); ^~~~~~~~~~ 1 warning generated. Cc: Alan Maguire Cc: Willem de Bruijn Fixes: 166b5a7f2ca3 ("selftests_bpf: extend test_tc_tunnel for UDP encap") Signed-off-by: Stanislav Fomichev Acked-by: Song Liu Reviewed-by: Alan Maguire --- tools/testing/selftests/bpf/progs/test_tc_tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/progs/test_tc_tunnel.c b/tools/testing/selftests/bpf/progs/test_tc_tunnel.c index bcb00d737e95..ab56a6a72b7a 100644 --- a/tools/testing/selftests/bpf/progs/test_tc_tunnel.c +++ b/tools/testing/selftests/bpf/progs/test_tc_tunnel.c @@ -157,7 +157,7 @@ static __always_inline int encap_ipv4(struct __sk_buff *skb, __u8 encap_proto, bpf_ntohs(h_outer.ip.tot_len)); h_outer.ip.protocol = encap_proto; - set_ipv4_csum(&h_outer.ip); + set_ipv4_csum((void *)&h_outer.ip); /* store new outer network header */ if (bpf_skb_store_bytes(skb, ETH_HLEN, &h_outer, olen,